chrome/browser/extensions/api/web_request/web_request_api_unittest.cc - Issue 22885002: c/b/extensions, json_schema_compiler: Do not use Value::Create*.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/web_request/web_request_api_unittest.cc

Issue 22885002: c/b/extensions, json_schema_compiler: Do not use Value::Create*. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Removed C-style casts. Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/web_request/web_request_api_helpers.cc ('k') | chrome/browser/extensions/api/webstore_private/webstore_private_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/web_request/web_request_api_unittest.cc

diff --git a/chrome/browser/extensions/api/web_request/web_request_api_unittest.cc b/chrome/browser/extensions/api/web_request/web_request_api_unittest.cc

index 6648611d4ded94a2b53d7354a5ce6210e4c4e7b9..1a712949f285a80eefc99b95b91517787c89113b 100644

--- a/chrome/browser/extensions/api/web_request/web_request_api_unittest.cc

+++ b/chrome/browser/extensions/api/web_request/web_request_api_unittest.cc

@@ -584,7 +584,7 @@ TEST_F(ExtensionWebRequestTest, AccessRequestBodyData) {

&raw);

extensions::subtle::AppendKeyValuePair(

keys::kRequestBodyRawFileKey,

- Value::CreateStringValue(std::string()),

+ new base::StringValue(std::string()),

&raw);

extensions::subtle::AppendKeyValuePair(

keys::kRequestBodyRawBytesKey,

@@ -1165,11 +1165,11 @@ TEST(ExtensionWebRequestHelpersTest,

TEST(ExtensionWebRequestHelpersTest, TestStringToCharList) {

ListValue list_value;

- list_value.Append(Value::CreateIntegerValue('1'));

- list_value.Append(Value::CreateIntegerValue('2'));

- list_value.Append(Value::CreateIntegerValue('3'));

- list_value.Append(Value::CreateIntegerValue(0xFE));

- list_value.Append(Value::CreateIntegerValue(0xD1));

+ list_value.Append(new base::FundamentalValue('1'));

+ list_value.Append(new base::FundamentalValue('2'));

+ list_value.Append(new base::FundamentalValue('3'));

+ list_value.Append(new base::FundamentalValue(0xFE));

+ list_value.Append(new base::FundamentalValue(0xD1));

unsigned char char_value[] = {'1', '2', '3', 0xFE, 0xD1};

std::string string_value(reinterpret_cast<char *>(char_value), 5);