chrome/browser/extensions/api/web_request/upload_data_presenter_unittest.cc - Issue 22885002: c/b/extensions, json_schema_compiler: Do not use Value::Create*.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/web_request/upload_data_presenter_unittest.cc

Issue 22885002: c/b/extensions, json_schema_compiler: Do not use Value::Create*. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Removed C-style casts. Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/web_request/upload_data_presenter.cc ('k') | chrome/browser/extensions/api/web_request/web_request_api_helpers.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/web_request/upload_data_presenter_unittest.cc

diff --git a/chrome/browser/extensions/api/web_request/upload_data_presenter_unittest.cc b/chrome/browser/extensions/api/web_request/upload_data_presenter_unittest.cc

index c4459828be5bd2f5255cca3a1f292286532d665b..2309d1ad50faf0547f990f1af574f6db7f8c5440 100644

--- a/chrome/browser/extensions/api/web_request/upload_data_presenter_unittest.cc

+++ b/chrome/browser/extensions/api/web_request/upload_data_presenter_unittest.cc

@@ -23,7 +23,7 @@ TEST(WebRequestUploadDataPresenterTest, ParsedData) {

// Expected output.

scoped_ptr<base::ListValue> values(new base::ListValue);

- values->Append(base::Value::CreateStringValue("value"));

+ values->Append(new base::StringValue("value"));

base::DictionaryValue expected_form;

expected_form.SetWithoutPathExpansion("key.with.dots", values.release());

@@ -52,7 +52,7 @@ TEST(WebRequestUploadDataPresenterTest, RawData) {

base::BinaryValue::CreateWithCopiedBuffer(block1, block1_size));

ASSERT_TRUE(expected_a.get() != NULL);

scoped_ptr<base::StringValue> expected_b(

- base::Value::CreateStringValue(kFilename));

+ new base::StringValue(kFilename));

ASSERT_TRUE(expected_b.get() != NULL);

scoped_ptr<base::BinaryValue> expected_c(

base::BinaryValue::CreateWithCopiedBuffer(block2, block2_size));