Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Side by Side Diff: chrome/browser/extensions/api/web_request/upload_data_presenter_unittest.cc

Issue 22885002: c/b/extensions, json_schema_compiler: Do not use Value::Create*. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Removed C-style casts. Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/basictypes.h" 5 #include "base/basictypes.h"
6 #include "base/values.h" 6 #include "base/values.h"
7 #include "chrome/browser/extensions/api/web_request/upload_data_presenter.h" 7 #include "chrome/browser/extensions/api/web_request/upload_data_presenter.h"
8 #include "chrome/browser/extensions/api/web_request/web_request_api_constants.h" 8 #include "chrome/browser/extensions/api/web_request/web_request_api_constants.h"
9 #include "net/base/upload_bytes_element_reader.h" 9 #include "net/base/upload_bytes_element_reader.h"
10 #include "testing/gtest/include/gtest/gtest.h" 10 #include "testing/gtest/include/gtest/gtest.h"
11 11
12 namespace keys = extension_web_request_api_constants; 12 namespace keys = extension_web_request_api_constants;
13 13
14 namespace extensions { 14 namespace extensions {
15 15
16 // This only tests the handling of dots in keys. Other functionality is covered 16 // This only tests the handling of dots in keys. Other functionality is covered
17 // by ExtensionWebRequestTest.AccessRequestBodyData and 17 // by ExtensionWebRequestTest.AccessRequestBodyData and
18 // WebRequestFormDataParserTest. 18 // WebRequestFormDataParserTest.
19 TEST(WebRequestUploadDataPresenterTest, ParsedData) { 19 TEST(WebRequestUploadDataPresenterTest, ParsedData) {
20 // Input. 20 // Input.
21 const char block[] = "key.with.dots=value"; 21 const char block[] = "key.with.dots=value";
22 net::UploadBytesElementReader element(block, sizeof(block) - 1); 22 net::UploadBytesElementReader element(block, sizeof(block) - 1);
23 23
24 // Expected output. 24 // Expected output.
25 scoped_ptr<base::ListValue> values(new base::ListValue); 25 scoped_ptr<base::ListValue> values(new base::ListValue);
26 values->Append(base::Value::CreateStringValue("value")); 26 values->Append(new base::StringValue("value"));
27 base::DictionaryValue expected_form; 27 base::DictionaryValue expected_form;
28 expected_form.SetWithoutPathExpansion("key.with.dots", values.release()); 28 expected_form.SetWithoutPathExpansion("key.with.dots", values.release());
29 29
30 // Real output. 30 // Real output.
31 scoped_ptr<ParsedDataPresenter> parsed_data_presenter( 31 scoped_ptr<ParsedDataPresenter> parsed_data_presenter(
32 ParsedDataPresenter::CreateForTests()); 32 ParsedDataPresenter::CreateForTests());
33 ASSERT_TRUE(parsed_data_presenter.get() != NULL); 33 ASSERT_TRUE(parsed_data_presenter.get() != NULL);
34 parsed_data_presenter->FeedNext(element); 34 parsed_data_presenter->FeedNext(element);
35 EXPECT_TRUE(parsed_data_presenter->Succeeded()); 35 EXPECT_TRUE(parsed_data_presenter->Succeeded());
36 scoped_ptr<base::Value> result = parsed_data_presenter->Result(); 36 scoped_ptr<base::Value> result = parsed_data_presenter->Result();
37 ASSERT_TRUE(result.get() != NULL); 37 ASSERT_TRUE(result.get() != NULL);
38 38
39 EXPECT_TRUE(result->Equals(&expected_form)); 39 EXPECT_TRUE(result->Equals(&expected_form));
40 } 40 }
41 41
42 TEST(WebRequestUploadDataPresenterTest, RawData) { 42 TEST(WebRequestUploadDataPresenterTest, RawData) {
43 // Input. 43 // Input.
44 const char block1[] = "test"; 44 const char block1[] = "test";
45 const size_t block1_size = sizeof(block1) - 1; 45 const size_t block1_size = sizeof(block1) - 1;
46 const char kFilename[] = "path/test_filename.ext"; 46 const char kFilename[] = "path/test_filename.ext";
47 const char block2[] = "another test"; 47 const char block2[] = "another test";
48 const size_t block2_size = sizeof(block2) - 1; 48 const size_t block2_size = sizeof(block2) - 1;
49 49
50 // Expected output. 50 // Expected output.
51 scoped_ptr<base::BinaryValue> expected_a( 51 scoped_ptr<base::BinaryValue> expected_a(
52 base::BinaryValue::CreateWithCopiedBuffer(block1, block1_size)); 52 base::BinaryValue::CreateWithCopiedBuffer(block1, block1_size));
53 ASSERT_TRUE(expected_a.get() != NULL); 53 ASSERT_TRUE(expected_a.get() != NULL);
54 scoped_ptr<base::StringValue> expected_b( 54 scoped_ptr<base::StringValue> expected_b(
55 base::Value::CreateStringValue(kFilename)); 55 new base::StringValue(kFilename));
56 ASSERT_TRUE(expected_b.get() != NULL); 56 ASSERT_TRUE(expected_b.get() != NULL);
57 scoped_ptr<base::BinaryValue> expected_c( 57 scoped_ptr<base::BinaryValue> expected_c(
58 base::BinaryValue::CreateWithCopiedBuffer(block2, block2_size)); 58 base::BinaryValue::CreateWithCopiedBuffer(block2, block2_size));
59 ASSERT_TRUE(expected_c.get() != NULL); 59 ASSERT_TRUE(expected_c.get() != NULL);
60 60
61 base::ListValue expected_list; 61 base::ListValue expected_list;
62 subtle::AppendKeyValuePair( 62 subtle::AppendKeyValuePair(
63 keys::kRequestBodyRawBytesKey, expected_a.release(), &expected_list); 63 keys::kRequestBodyRawBytesKey, expected_a.release(), &expected_list);
64 subtle::AppendKeyValuePair( 64 subtle::AppendKeyValuePair(
65 keys::kRequestBodyRawFileKey, expected_b.release(), &expected_list); 65 keys::kRequestBodyRawFileKey, expected_b.release(), &expected_list);
66 subtle::AppendKeyValuePair( 66 subtle::AppendKeyValuePair(
67 keys::kRequestBodyRawBytesKey, expected_c.release(), &expected_list); 67 keys::kRequestBodyRawBytesKey, expected_c.release(), &expected_list);
68 68
69 // Real output. 69 // Real output.
70 RawDataPresenter raw_presenter; 70 RawDataPresenter raw_presenter;
71 raw_presenter.FeedNextBytes(block1, block1_size); 71 raw_presenter.FeedNextBytes(block1, block1_size);
72 raw_presenter.FeedNextFile(kFilename); 72 raw_presenter.FeedNextFile(kFilename);
73 raw_presenter.FeedNextBytes(block2, block2_size); 73 raw_presenter.FeedNextBytes(block2, block2_size);
74 EXPECT_TRUE(raw_presenter.Succeeded()); 74 EXPECT_TRUE(raw_presenter.Succeeded());
75 scoped_ptr<base::Value> result = raw_presenter.Result(); 75 scoped_ptr<base::Value> result = raw_presenter.Result();
76 ASSERT_TRUE(result.get() != NULL); 76 ASSERT_TRUE(result.get() != NULL);
77 77
78 EXPECT_TRUE(result->Equals(&expected_list)); 78 EXPECT_TRUE(result->Equals(&expected_list));
79 } 79 }
80 80
81 } // namespace extensions 81 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698