chrome/browser/extensions/menu_manager.h - Issue 22885002: c/b/extensions, json_schema_compiler: Do not use Value::Create*.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/menu_manager.h

Issue 22885002: c/b/extensions, json_schema_compiler: Do not use Value::Create*. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Trying one last time get past Base Files Missing. Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/api/extension_action/extension_action_api.cc ('K') | « chrome/browser/extensions/extension_special_storage_policy_unittest.cc ('k') | chrome/browser/extensions/menu_manager_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/menu_manager.h

diff --git a/chrome/browser/extensions/menu_manager.h b/chrome/browser/extensions/menu_manager.h

index 764e8616804e82999573476916c753ef0bcbbc94..4804c4a411acbcf8b8e232bce5c7c6665f2b5a31 100644

--- a/chrome/browser/extensions/menu_manager.h

+++ b/chrome/browser/extensions/menu_manager.h

@@ -110,7 +110,7 @@ class MenuItem {

}

scoped_ptr<base::Value> ToValue() const {

- return scoped_ptr<base::Value>(base::Value::CreateIntegerValue(value_));

+ return scoped_ptr<base::Value>(new base::FundamentalValue((int)value_));

}

bool Populate(const base::Value& value) {