chrome/browser/extensions/api/web_navigation/web_navigation_api_helpers.cc - Issue 22885002: c/b/extensions, json_schema_compiler: Do not use Value::Create*.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/web_navigation/web_navigation_api_helpers.cc

Issue 22885002: c/b/extensions, json_schema_compiler: Do not use Value::Create*. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Trying one last time get past Base Files Missing. Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/api/extension_action/extension_action_api.cc ('K') | « chrome/browser/extensions/api/usb/usb_api.cc ('k') | chrome/browser/extensions/api/web_request/upload_data_presenter.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/web_navigation/web_navigation_api_helpers.cc

diff --git a/chrome/browser/extensions/api/web_navigation/web_navigation_api_helpers.cc b/chrome/browser/extensions/api/web_navigation/web_navigation_api_helpers.cc

index 86213ee75b1a8286ce8bac66f3d036c9935020e8..b684650817ffca6cec2a29bfc119ef058bc06b33 100644

--- a/chrome/browser/extensions/api/web_navigation/web_navigation_api_helpers.cc

+++ b/chrome/browser/extensions/api/web_navigation/web_navigation_api_helpers.cc

@@ -102,13 +102,13 @@ void DispatchOnCommitted(const char* event_name,

content::PageTransitionGetCoreTransitionString(transition_type));

base::ListValue* qualifiers = new base::ListValue();

if (transition_type & content::PAGE_TRANSITION_CLIENT_REDIRECT)

- qualifiers->Append(Value::CreateStringValue("client_redirect"));

+ qualifiers->Append(new base::StringValue("client_redirect"));

if (transition_type & content::PAGE_TRANSITION_SERVER_REDIRECT)

- qualifiers->Append(Value::CreateStringValue("server_redirect"));

+ qualifiers->Append(new base::StringValue("server_redirect"));

if (transition_type & content::PAGE_TRANSITION_FORWARD_BACK)

- qualifiers->Append(Value::CreateStringValue("forward_back"));

+ qualifiers->Append(new base::StringValue("forward_back"));

if (transition_type & content::PAGE_TRANSITION_FROM_ADDRESS_BAR)

- qualifiers->Append(Value::CreateStringValue("from_address_bar"));

+ qualifiers->Append(new base::StringValue("from_address_bar"));

dict->Set(keys::kTransitionQualifiersKey, qualifiers);

dict->SetDouble(keys::kTimeStampKey, MilliSecondsFromTime(base::Time::Now()));

args->Append(dict);