chrome/browser/extensions/api/storage/settings_test_util.cc - Issue 22885002: c/b/extensions, json_schema_compiler: Do not use Value::Create*.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/storage/settings_test_util.cc

Issue 22885002: c/b/extensions, json_schema_compiler: Do not use Value::Create*. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Trying one last time get past Base Files Missing. Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/api/extension_action/extension_action_api.cc ('K') | « chrome/browser/extensions/api/storage/settings_sync_unittest.cc ('k') | chrome/browser/extensions/api/storage/storage_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/storage/settings_test_util.cc

diff --git a/chrome/browser/extensions/api/storage/settings_test_util.cc b/chrome/browser/extensions/api/storage/settings_test_util.cc

index 07b635efc07e64e91bea6376d8df78f810561f79..82c1845fb82b63307cf2020aacd7c2858499cdcf 100644

--- a/chrome/browser/extensions/api/storage/settings_test_util.cc

+++ b/chrome/browser/extensions/api/storage/settings_test_util.cc

@@ -68,7 +68,7 @@ void MockExtensionService::AddExtensionWithIdAndPermissions(

scoped_ptr<base::ListValue> permissions(new base::ListValue());

for (std::set<std::string>::const_iterator it = permissions_set.begin();

it != permissions_set.end(); ++it) {

- permissions->Append(Value::CreateStringValue(*it));

+ permissions->Append(new base::StringValue(*it));

}

manifest.Set("permissions", permissions.release());