chrome/browser/extensions/api/storage/settings_quota_unittest.cc - Issue 22885002: c/b/extensions, json_schema_compiler: Do not use Value::Create*.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/storage/settings_quota_unittest.cc

Issue 22885002: c/b/extensions, json_schema_compiler: Do not use Value::Create*. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Trying one last time get past Base Files Missing. Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/api/extension_action/extension_action_api.cc ('K') | « chrome/browser/extensions/api/storage/settings_frontend_unittest.cc ('k') | chrome/browser/extensions/api/storage/settings_sync_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/storage/settings_quota_unittest.cc

diff --git a/chrome/browser/extensions/api/storage/settings_quota_unittest.cc b/chrome/browser/extensions/api/storage/settings_quota_unittest.cc

index 0e4ea79ab8572e0999c9f7f4e2bdd5bd246daaa3..d64c42c0b0d96fc3d170763e9158b1325eaf0155 100644

--- a/chrome/browser/extensions/api/storage/settings_quota_unittest.cc

+++ b/chrome/browser/extensions/api/storage/settings_quota_unittest.cc

@@ -25,12 +25,12 @@ const ValueStore::WriteOptions IGNORE_QUOTA =

class ExtensionSettingsQuotaTest : public testing::Test {

public:

ExtensionSettingsQuotaTest()

- : byte_value_1_(Value::CreateIntegerValue(1)),

- byte_value_16_(Value::CreateStringValue("sixteen bytes.")),

+ : byte_value_1_(new base::FundamentalValue(1)),

+ byte_value_16_(new base::StringValue("sixteen bytes.")),

byte_value_256_(new ListValue()),

delegate_(new TestingValueStore()) {

for (int i = 1; i < 89; ++i) {

- byte_value_256_->Append(Value::CreateIntegerValue(i));

+ byte_value_256_->Append(new base::FundamentalValue(i));

}

ValidateByteValues();

}