chrome/browser/extensions/api/storage/policy_value_store_unittest.cc - Issue 22885002: c/b/extensions, json_schema_compiler: Do not use Value::Create*.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/storage/policy_value_store_unittest.cc

Issue 22885002: c/b/extensions, json_schema_compiler: Do not use Value::Create*. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Trying one last time get past Base Files Missing. Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/api/extension_action/extension_action_api.cc ('K') | « chrome/browser/extensions/api/socket/socket_api.cc ('k') | chrome/browser/extensions/api/storage/settings_frontend.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/storage/policy_value_store_unittest.cc

diff --git a/chrome/browser/extensions/api/storage/policy_value_store_unittest.cc b/chrome/browser/extensions/api/storage/policy_value_store_unittest.cc

index 56f473e67f8834722edf981c79e18299e86ca27e..e554b327169356f8148d88b2839ae479d386717b 100644

--- a/chrome/browser/extensions/api/storage/policy_value_store_unittest.cc

+++ b/chrome/browser/extensions/api/storage/policy_value_store_unittest.cc

@@ -124,7 +124,7 @@ TEST_F(PolicyValueStoreTest, DontProvideRecommendedPolicies) {

policy::POLICY_SCOPE_USER, expected.DeepCopy(), NULL);

policies.Set("may", policy::POLICY_LEVEL_RECOMMENDED,

policy::POLICY_SCOPE_USER,

- base::Value::CreateIntegerValue(456), NULL);

+ new base::FundamentalValue(456), NULL);

store_->SetCurrentPolicy(policies, false);

ValueStore::ReadResult result = store_->Get();

ASSERT_FALSE(result->HasError());

@@ -155,7 +155,7 @@ TEST_F(PolicyValueStoreTest, ReadOnly) {

TEST_F(PolicyValueStoreTest, NotifyOnChanges) {

policy::PolicyMap policies;

policies.Set("aaa", policy::POLICY_LEVEL_MANDATORY, policy::POLICY_SCOPE_USER,

- base::Value::CreateStringValue("111"), NULL);

+ new base::StringValue("111"), NULL);

EXPECT_CALL(observer_, OnSettingsChanged(_, _, _)).Times(0);

// No notification when setting the initial policy.

store_->SetCurrentPolicy(policies, false);

@@ -164,9 +164,9 @@ TEST_F(PolicyValueStoreTest, NotifyOnChanges) {

// And no notifications on changes when not asked for.

policies.Set("aaa", policy::POLICY_LEVEL_MANDATORY, policy::POLICY_SCOPE_USER,

- base::Value::CreateStringValue("222"), NULL);

+ new base::StringValue("222"), NULL);

policies.Set("bbb", policy::POLICY_LEVEL_MANDATORY, policy::POLICY_SCOPE_USER,

- base::Value::CreateStringValue("223"), NULL);

+ new base::StringValue("223"), NULL);

EXPECT_CALL(observer_, OnSettingsChanged(_, _, _)).Times(0);

store_->SetCurrentPolicy(policies, false);

loop_.RunUntilIdle();