chrome/browser/extensions/api/identity/experimental_identity_api.cc - Issue 22885002: c/b/extensions, json_schema_compiler: Do not use Value::Create*.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/identity/experimental_identity_api.cc

Issue 22885002: c/b/extensions, json_schema_compiler: Do not use Value::Create*. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Trying one last time get past Base Files Missing. Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/api/extension_action/extension_action_api.cc ('K') | « chrome/browser/extensions/api/font_settings/font_settings_api.cc ('k') | chrome/browser/extensions/api/identity/identity_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/identity/experimental_identity_api.cc

diff --git a/chrome/browser/extensions/api/identity/experimental_identity_api.cc b/chrome/browser/extensions/api/identity/experimental_identity_api.cc

index 2e01c4ec656e4cb83209b0887ba01eb78b6370ce..11e24081ab2160ab41c95aac8b8272919e31259a 100644

--- a/chrome/browser/extensions/api/identity/experimental_identity_api.cc

+++ b/chrome/browser/extensions/api/identity/experimental_identity_api.cc

@@ -102,7 +102,7 @@ bool ExperimentalIdentityGetAuthTokenFunction::RunImpl() {

void ExperimentalIdentityGetAuthTokenFunction::CompleteFunctionWithResult(

const std::string& access_token) {

- SetResult(Value::CreateStringValue(access_token));

+ SetResult(new base::StringValue(access_token));

SendResponse(true);

Release(); // Balanced in RunImpl.

}

@@ -385,7 +385,7 @@ void ExperimentalIdentityLaunchWebAuthFlowFunction::OnAuthFlowFailure(

void ExperimentalIdentityLaunchWebAuthFlowFunction::OnAuthFlowURLChange(

const GURL& redirect_url) {

if (IsFinalRedirectURL(redirect_url)) {

- SetResult(Value::CreateStringValue(redirect_url.spec()));

+ SetResult(new base::StringValue(redirect_url.spec()));

SendResponse(true);

Release(); // Balanced in RunImpl.

}