c/b/extensions, json_schema_compiler: Do not use Value::Create*.

chrome/browser/extensions/api/extension_action/extension_action_api.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/api/extension_action/extension_action_api.h"
 
 #include <string>
 
 #include "base/base64.h"
 #include "base/lazy_instance.h"
@@ skipping 235 matching lines @@
 // static
 void ExtensionActionAPI::SetBrowserActionVisibility(
     ExtensionPrefs* prefs,
     const std::string& extension_id,
     bool visible) {
   if (GetBrowserActionVisibility(prefs, extension_id) == visible)
     return;
 
   prefs->UpdateExtensionPref(extension_id,
                              kBrowserActionVisible,
-                             Value::CreateBooleanValue(visible));
+                             new base::FundamentalValue(visible));
   content::NotificationService::current()->Notify(
       chrome::NOTIFICATION_EXTENSION_BROWSER_ACTION_VISIBILITY_CHANGED,
       content::Source<ExtensionPrefs>(prefs),
       content::Details<const std::string>(&extension_id));
 }
 
 //
 // ExtensionActionStorageManager
 //
 
@@ skipping 381 matching lines @@
     if (!ParseCSSColorString(color_string, &color))
       return false;
   }
 
   extension_action_->SetBadgeBackgroundColor(tab_id_, color);
   NotifyChange();
   return true;
 }
 
 bool ExtensionActionGetTitleFunction::RunExtensionAction() {
-  SetResult(Value::CreateStringValue(extension_action_->GetTitle(tab_id_)));
+  SetResult(new base::StringValue(extension_action_->GetTitle(tab_id_)));
   return true;
 }
 
 bool ExtensionActionGetPopupFunction::RunExtensionAction() {
   SetResult(
-      Value::CreateStringValue(extension_action_->GetPopupUrl(tab_id_).spec()));
+      new base::StringValue(extension_action_->GetPopupUrl(tab_id_).spec()));
   return true;
 }
 
 bool ExtensionActionGetBadgeTextFunction::RunExtensionAction() {
-  SetResult(Value::CreateStringValue(extension_action_->GetBadgeText(tab_id_)));
+  SetResult(new base::StringValue(extension_action_->GetBadgeText(tab_id_)));
   return true;
 }
 
 bool ExtensionActionGetBadgeBackgroundColorFunction::RunExtensionAction() {
   base::ListValue* list = new base::ListValue();
   SkColor color = extension_action_->GetBadgeBackgroundColor(tab_id_);
-  list->Append(Value::CreateIntegerValue(SkColorGetR(color)));
-  list->Append(Value::CreateIntegerValue(SkColorGetG(color)));
-  list->Append(Value::CreateIntegerValue(SkColorGetB(color)));
-  list->Append(Value::CreateIntegerValue(SkColorGetA(color)));
+  list->Append(new base::FundamentalValue((int)SkColorGetR(color)));

[not at google - send to devlin, 2013/08/12 20:59:48]

do you really need a cast here? if so it sadly needs to be static_cast.

[dhnishi (use Chromium), 2013/08/12 23:40:40]

Done.

It unfortunately didn't know which FundamentalValue constructor to use without
casting. It wasn't a problem before because the CreateIntegerValue just knew,
but that it's just an overloaded constructor it was ambiguous.

+  list->Append(new base::FundamentalValue((int)SkColorGetG(color)));
+  list->Append(new base::FundamentalValue((int)SkColorGetB(color)));
+  list->Append(new base::FundamentalValue((int)SkColorGetA(color)));
   SetResult(list);
   return true;
 }
 
 //
 // ScriptBadgeGetAttentionFunction
 //
 
 ScriptBadgeGetAttentionFunction::~ScriptBadgeGetAttentionFunction() {}
 
@@ skipping 69 matching lines @@
   return true;
 }
 
 bool EnablePageActionsFunction::RunImpl() {
   return SetPageActionEnabled(true);
 }
 
 bool DisablePageActionsFunction::RunImpl() {
   return SetPageActionEnabled(false);
 }