chrome/browser/extensions/api/discovery/discovery_api_unittest.cc - Issue 22885002: c/b/extensions, json_schema_compiler: Do not use Value::Create*.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/discovery/discovery_api_unittest.cc

Issue 22885002: c/b/extensions, json_schema_compiler: Do not use Value::Create*. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Trying one last time get past Base Files Missing. Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/dial/dial_api.cc ('k') | chrome/browser/extensions/api/downloads/downloads_api.cc » ('j') | chrome/browser/extensions/api/extension_action/extension_action_api.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/discovery/discovery_api_unittest.cc

diff --git a/chrome/browser/extensions/api/discovery/discovery_api_unittest.cc b/chrome/browser/extensions/api/discovery/discovery_api_unittest.cc

index 223bc16c883abff3ede2607c758ee1d5cea6c6bd..c01a226d6cacaed3b80257bfd2c205d6e266b045 100644

--- a/chrome/browser/extensions/api/discovery/discovery_api_unittest.cc

+++ b/chrome/browser/extensions/api/discovery/discovery_api_unittest.cc

@@ -58,7 +58,7 @@ std::string SuggestParamsToJSON(const std::string& link_url,

std::string RemoveSuggestionParamsToJSON(const std::string& link_url) {

std::string result;

base::ListValue params;

- params.Append(base::Value::CreateStringValue(link_url));

+ params.Append(new base::StringValue(link_url));

base::JSONWriter::Write(&params, &result);

return result;

}