chrome/browser/extensions/api/cloud_print_private/cloud_print_private_api.cc - Issue 22885002: c/b/extensions, json_schema_compiler: Do not use Value::Create*.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/cloud_print_private/cloud_print_private_api.cc

Issue 22885002: c/b/extensions, json_schema_compiler: Do not use Value::Create*. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Trying one last time get past Base Files Missing. Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/bluetooth/bluetooth_api.cc ('k') | chrome/browser/extensions/api/commands/command_service.cc » ('j') | chrome/browser/extensions/api/extension_action/extension_action_api.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/cloud_print_private/cloud_print_private_api.cc

diff --git a/chrome/browser/extensions/api/cloud_print_private/cloud_print_private_api.cc b/chrome/browser/extensions/api/cloud_print_private/cloud_print_private_api.cc

index a2529d6e6736615ec2d3f236fb6ba330eb313fd6..c30d6dae6b0235dd0ceebab3b001bab4baa720b0 100644

--- a/chrome/browser/extensions/api/cloud_print_private/cloud_print_private_api.cc

+++ b/chrome/browser/extensions/api/cloud_print_private/cloud_print_private_api.cc

@@ -69,7 +69,7 @@ CloudPrintPrivateGetHostNameFunction::~CloudPrintPrivateGetHostNameFunction() {

}

bool CloudPrintPrivateGetHostNameFunction::RunImpl() {

- SetResult(Value::CreateStringValue(

+ SetResult(new base::StringValue(

CloudPrintTestsDelegate::instance() ?

CloudPrintTestsDelegate::instance()->GetHostName() :

net::GetHostName()));

@@ -111,7 +111,7 @@ CloudPrintPrivateGetClientIdFunction::~CloudPrintPrivateGetClientIdFunction() {

}

bool CloudPrintPrivateGetClientIdFunction::RunImpl() {

- SetResult(Value::CreateStringValue(

+ SetResult(new base::StringValue(

CloudPrintTestsDelegate::instance() ?

CloudPrintTestsDelegate::instance()->GetClientId() :

google_apis::GetOAuth2ClientID(google_apis::CLIENT_CLOUD_PRINT)));