third_party/WebKit/Source/wtf/Assertions.h - Issue 2288473002: Implement Dump-on-DCHECK (via a new LogSeverity).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/wtf/Assertions.h

Issue 2288473002: Implement Dump-on-DCHECK (via a new LogSeverity). (Closed)

Patch Set: Pull the Official Windows build default in, and rebase Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/wtf/Assertions.h

diff --git a/third_party/WebKit/Source/wtf/Assertions.h b/third_party/WebKit/Source/wtf/Assertions.h

index 4f9b24e207fa15ac027127735d79f10fbdd3ae06..44d98b1a1c352e3a0620c0197c9da2d5c2c8cf2e 100644

--- a/third_party/WebKit/Source/wtf/Assertions.h

+++ b/third_party/WebKit/Source/wtf/Assertions.h

@@ -134,9 +134,10 @@ class WTF_EXPORT ScopedLogger {

#undef ASSERT

#endif

-#define DCHECK_AT(assertion, file, line) \

- LAZY_STREAM(logging::LogMessage(file, line, #assertion).stream(), \

- DCHECK_IS_ON() ? !(assertion) : false)

+#define DCHECK_AT(assertion, file, line) \

+ LAZY_STREAM(logging::LogMessage(file, line, logging::LOG_DCHECK).stream(), \

+ DCHECK_IS_ON() ? !(assertion) : false) \

+ << "Check failed: " #assertion ". "

#if DCHECK_IS_ON()

#define ASSERT(assertion) DCHECK(assertion)

« no previous file with comments | « build/config/dcheck_always_on.gni ('k') | third_party/WebKit/Source/wtf/AssertionsTest.cpp » ('j') | no next file with comments »