Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2823)

Unified Diff: build/config/dcheck_always_on.gni

Issue 2288473002: Implement Dump-on-DCHECK (via a new LogSeverity). (Closed)
Patch Set: Pull the Official Windows build default in, and rebase Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/config/BUILD.gn ('k') | third_party/WebKit/Source/wtf/Assertions.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/dcheck_always_on.gni
diff --git a/build/config/dcheck_always_on.gni b/build/config/dcheck_always_on.gni
index 60672cdf50e6d22e5bff5b04d972976b084e3f05..d31f69431b951c281a1f9b3ebb94548b7ffa7076 100644
--- a/build/config/dcheck_always_on.gni
+++ b/build/config/dcheck_always_on.gni
@@ -4,5 +4,12 @@
declare_args() {
# Set to true to enable dcheck in Release builds.
- dcheck_always_on = false
+ # TODO(596231): Default to enabled on Windows Official builds.
+ dcheck_always_on = is_official_build && is_win
+
+ # Set to true to have the first failed dcheck cause a dump to be
+ # uploaded, without crashing. Implies dcheck_always_on, but does not
+ # actually enable logging of dcheck failures.
+ # TODO(596231): Default to enabled on Windows Official builds.
+ dump_on_first_dcheck = is_official_build && is_win
}
« no previous file with comments | « build/config/BUILD.gn ('k') | third_party/WebKit/Source/wtf/Assertions.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698