Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3335)

Unified Diff: base/debug/dump_without_crashing.h

Issue 2288473002: Implement Dump-on-DCHECK (via a new LogSeverity). (Closed)
Patch Set: Migrate some tests to EXPECT_DCHECK_DEATH Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | base/debug/dump_without_crashing.cc » ('j') | base/logging.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/debug/dump_without_crashing.h
diff --git a/base/debug/dump_without_crashing.h b/base/debug/dump_without_crashing.h
index b8ed17414ac571cddaf435ea978b3fd3e1bb811f..a5c85d5ebeace6991a98b1616d3b0c6c38c3dee1 100644
--- a/base/debug/dump_without_crashing.h
+++ b/base/debug/dump_without_crashing.h
@@ -17,7 +17,8 @@ namespace debug {
// Before calling this function, call SetDumpWithoutCrashingFunction to pass a
// function pointer, typically chrome!DumpProcessWithoutCrash. See example code
// in chrome_main.cc that does this for chrome.dll.
-BASE_EXPORT void DumpWithoutCrashing();
+// Returns false if called before SetDumpWithoutCrashingFunction.
+BASE_EXPORT bool DumpWithoutCrashing();
Wez 2016/12/19 23:57:46 Some new call-sites have been introduced lately wh
// Sets a function that'll be invoked to dump the current process when
// DumpWithoutCrashing() is called.
« no previous file with comments | « no previous file | base/debug/dump_without_crashing.cc » ('j') | base/logging.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698