Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Unified Diff: base/debug/dump_without_crashing.cc

Issue 2288473002: Implement Dump-on-DCHECK (via a new LogSeverity). (Closed)
Patch Set: Migrate some tests to EXPECT_DCHECK_DEATH Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/debug/dump_without_crashing.cc
diff --git a/base/debug/dump_without_crashing.cc b/base/debug/dump_without_crashing.cc
index 47fd873c19fd084c51d5e48455db040269ca47b3..4b338ca2930b69d110fd545176029aec75f9cd4a 100644
--- a/base/debug/dump_without_crashing.cc
+++ b/base/debug/dump_without_crashing.cc
@@ -18,9 +18,12 @@ namespace base {
namespace debug {
-void DumpWithoutCrashing() {
- if (dump_without_crashing_function_)
+bool DumpWithoutCrashing() {
+ if (dump_without_crashing_function_) {
(*dump_without_crashing_function_)();
+ return true;
+ }
+ return false;
}
void SetDumpWithoutCrashingFunction(void (CDECL *function)()) {

Powered by Google App Engine
This is Rietveld 408576698