Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(463)

Unified Diff: tools/perf/page_sets/endure_calendar_forward_backward.json

Issue 22883011: Removing Page.WaitToLoad and update all pagesets to use explicit wait actions (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/perf/page_sets/endure_calendar_forward_backward.json
diff --git a/tools/perf/page_sets/endure_calendar_forward_backward.json b/tools/perf/page_sets/endure_calendar_forward_backward.json
index 27d9b74995c1811f48354bf912191b8e963bccc0..aec0de683651158646e8b16a2fd71cca0ca3b251 100644
--- a/tools/perf/page_sets/endure_calendar_forward_backward.json
+++ b/tools/perf/page_sets/endure_calendar_forward_backward.json
@@ -8,49 +8,28 @@
"url": "https://www.google.com/calendar/",
"why": "Click forward(4x) and backwards(4x) repeatedly",
"credentials": "google",
- "wait_for_element_with_selector": "div[class~=\"navForward\"]",
- "post_navigate_javascript_to_execute": "(function() { var elem = document.createElement('meta');elem.name='viewport';elem.content='initial-scale=1';document.body.appendChild(elem); })();",
+ "navigate_steps" : [
+ { "action": "navigate"},
+ { "action": "wait", "condition": "element", "selector": "div[class~=\"navForward\"]"},
+ { "action": "javascript", "expression": "(function() { var elem = document.createElement('meta');elem.name='viewport';elem.content='initial-scale=1';document.body.appendChild(elem); })();"}
+ ],
"endure": [
- {
- "action": "click_element",
- "selector": "div[class~=\"navForward\"]",
- "wait_for_element_with_selector": "div[class~=\"navForward\"]"
- },
- {
- "action": "click_element",
- "selector": "div[class~=\"navForward\"]",
- "wait_for_element_with_selector": "div[class~=\"navForward\"]"
- },
- {
- "action": "click_element",
- "selector": "div[class~=\"navForward\"]",
- "wait_for_element_with_selector": "div[class~=\"navForward\"]"
- },
- {
- "action": "click_element",
- "selector": "div[class~=\"navForward\"]",
- "wait_for_element_with_selector": "div[class~=\"navBack\"]"
- },
- {
- "action": "click_element",
- "selector": "div[class~=\"navBack\"]",
- "wait_for_element_with_selector": "div[class~=\"navBack\"]"
- },
- {
- "action": "click_element",
- "selector": "div[class~=\"navBack\"]",
- "wait_for_element_with_selector": "div[class~=\"navBack\"]"
- },
- {
- "action": "click_element",
- "selector": "div[class~=\"navBack\"]",
- "wait_for_element_with_selector": "div[class~=\"navBack\"]"
- },
- {
- "action": "click_element",
- "selector": "div[class~=\"navBack\"]",
- "wait_for_element_with_selector": "div[class~=\"navForward\"]"
- }
+ { "action": "click_element", "selector": "div[class~=\"navForward\"]" },
+ { "action": "wait", "condition": "element", "selector": "div[class~=\"navForward\"]" },
+ { "action": "click_element", "selector": "div[class~=\"navForward\"]" },
+ { "action": "wait", "condition": "element", "selector": "div[class~=\"navForward\"]" },
+ { "action": "click_element", "selector": "div[class~=\"navForward\"]" },
+ { "action": "wait", "condition": "element", "selector": "div[class~=\"navForward\"]" },
+ { "action": "click_element", "selector": "div[class~=\"navForward\"]" },
+ { "action": "wait", "condition": "element", "selector": "div[class~=\"navBack\"]" },
+ { "action": "click_element", "selector": "div[class~=\"navBack\"]" },
+ { "action": "wait", "condition": "element", "selector": "div[class~=\"navBack\"]" },
+ { "action": "click_element", "selector": "div[class~=\"navBack\"]" },
+ { "action": "wait", "condition": "element", "selector": "div[class~=\"navBack\"]" },
+ { "action": "click_element", "selector": "div[class~=\"navBack\"]" },
+ { "action": "wait", "condition": "element", "selector": "div[class~=\"navBack\"]" },
+ { "action": "click_element", "selector": "div[class~=\"navBack\"]" },
+ { "action": "wait", "condition": "element", "selector": "div[class~=\"navForward\"]" }
]
}
]

Powered by Google App Engine
This is Rietveld 408576698