tools/perf/page_sets/2012Q3.json - Issue 22883011: Removing Page.WaitToLoad and update all pagesets to use explicit wait actions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/page_sets/2012Q3.json

Issue 22883011: Removing Page.WaitToLoad and update all pagesets to use explicit wait actions (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: . Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/test/gpu/page_sets/pixel_tests.json ('K') | « content/test/gpu/page_sets/pixel_tests.json ('k') | tools/perf/page_sets/endure_calendar_forward_backward.json » ('j') | tools/perf/page_sets/mobile_memory.json » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/perf/page_sets/2012Q3.json

diff --git a/tools/perf/page_sets/2012Q3.json b/tools/perf/page_sets/2012Q3.json

index 151a1d650d9141b164dc518ecae381ac5a520223..47a938dffdce15526206c278c9a04a678310545e 100644

--- a/tools/perf/page_sets/2012Q3.json

+++ b/tools/perf/page_sets/2012Q3.json

@@ -3,7 +3,11 @@

"archive_data_file": "../data/2012Q3.json",

"credentials_path": "../data/credentials.json",

"smoothness": { "action": "scroll" },

- "reload_and_gc": [{"action": "reload", "wait_seconds": 1}, {"action": "js_collect_garbage"}],

+ "reload_and_gc": [

+ {"action": "reload"},

+ {"action": "wait", "condition": "seconds", "seconds": 1},

tonyg 2013/08/21 00:04:33 Or should this be "condition": "duration"?

+ {"action": "js_collect_garbage"}

+ ],

"stress_memory": { "action": "reload_and_gc", "repeat": 3 },

"pages": [

{ "url": "http://www.facebook.com/barackobama" },