[Chromecast] Rename disable_display flag to is_cast_audio_only.

[Chromecast] Rename disable_display flag to is_cast_audio_only.

The disable_display flag is problematic in two ways:
 * It is not obviously Cast-specific from the name.
 * It is not named in the affirmative.

Fix these two problems by renaming this flag to is_cast_audio_only.

BUG=627641
Committed: https://crrev.com/a0671e41e14616132fcc8d2bde0c8349e15f334a
Cr-Commit-Position: refs/heads/master@{#415941}

[slan, 2016-08-29 15:33:48]

slan@chromium.org changed reviewers:
+ alokp@chromium.org, halliwell@chromium.org, lcwu@chromium.org,
wzhong@chromium.org

[slan, 2016-08-29 15:33:48]

+brettw for FYI

Chromecast folks: I will CC you on the corresponding internal change. This will
be cherry-picked to unfork_m52 as well.

PTAL!

[slan, 2016-08-29 15:35:06]

The CQ bit was checked by slan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-29 15:35:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[halliwell, 2016-08-29 15:47:05]

On 2016/08/29 15:33:48, slan wrote:
> +brettw for FYI
> 
> Chromecast folks: I will CC you on the corresponding internal change. This
will
> be cherry-picked to unfork_m52 as well.
> 
> PTAL!

lgtm

[wzhong, 2016-08-29 15:51:21]

lgtm

[commit-bot: I haz the power, 2016-08-29 15:54:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-29 15:54:19]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[slan, 2016-08-29 16:14:29]

The CQ bit was checked by slan@chromium.org

[slan, 2016-08-29 16:14:29]

The patchset sent to the CQ was uploaded after l-g-t-m from wzhong@chromium.org,
halliwell@chromium.org
Link to the patchset: https://codereview.chromium.org/2288283002/#ps20001
(title: "Pick up missing callsites")

[commit-bot: I haz the power, 2016-08-29 16:16:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-29 16:29:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-29 16:29:44]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[slan, 2016-08-29 16:58:48]

slan@chromium.org changed reviewers:
+ dalecurtis@chromium.org, dpranke@google.com, spang@chromium.org

[slan, 2016-08-29 16:58:48]

Adding missing OWNERS:
+ Dirk for build/config/chromecast.gni
+ Dale for media/media_options.gni
+ Michael for ui/ozone/ozone.gni

[Dirk Pranke, 2016-08-29 18:23:38]

dpranke@chromium.org changed reviewers:
+ dpranke@chromium.org

[Dirk Pranke, 2016-08-29 18:23:38]

lgtm

https://codereview.chromium.org/2288283002/diff/20001/build/config/chromecast...
File build/config/chromecast_build.gni (right):

https://codereview.chromium.org/2288283002/diff/20001/build/config/chromecast...
build/config/chromecast_build.gni:36: assert(is_chromecast || !(cast_audio_only
|| is_cast_desktop_build))
nit: this might be a bit clearer (to me, at least) as:

assert(is_chromecast) || (!cast_audio_only && !is_cast_desktop_build))

though I realize it evaluates the same either way.

[DaleCurtis, 2016-08-29 19:09:30]

Shouldn't this be is_cast_audio_only?

[slan, 2016-08-29 21:36:02]

On 2016/08/29 19:09:30, DaleCurtis wrote:
> Shouldn't this be is_cast_audio_only?

Yep, I agree. Done.

[slan, 2016-08-29 21:36:22]

On 2016/08/29 18:23:38, Dirk Pranke wrote:
> lgtm
> 
>
https://codereview.chromium.org/2288283002/diff/20001/build/config/chromecast...
> File build/config/chromecast_build.gni (right):
> 
>
https://codereview.chromium.org/2288283002/diff/20001/build/config/chromecast...
> build/config/chromecast_build.gni:36: assert(is_chromecast ||
!(cast_audio_only
> || is_cast_desktop_build))
> nit: this might be a bit clearer (to me, at least) as:
> 
> assert(is_chromecast) || (!cast_audio_only && !is_cast_desktop_build))
> 
> though I realize it evaluates the same either way.

Done.

[DaleCurtis, 2016-08-29 21:41:58]

lgtm

[slan, 2016-08-29 21:42:59]

Description was changed from

==========
[Chromecast] Rename disable_display flag to cast_audio_only.

The disable_display flag is problematic in two ways:
 * It is not obviously Cast-specific from the name.
 * It is not named in the affirmative.

Fix these two problems by renaming this flag to cast_audio_only.

BUG=627641
==========

to

==========
[Chromecast] Rename disable_display flag to is_cast_audio_only.

The disable_display flag is problematic in two ways:
 * It is not obviously Cast-specific from the name.
 * It is not named in the affirmative.

Fix these two problems by renaming this flag to is_cast_audio_only.

BUG=627641
==========

[spang, 2016-08-29 21:47:18]

lgtm

[slan, 2016-08-29 21:48:03]

The CQ bit was checked by slan@chromium.org

[slan, 2016-08-29 21:48:03]

The patchset sent to the CQ was uploaded after l-g-t-m from
dpranke@chromium.org, wzhong@chromium.org, halliwell@chromium.org
Link to the patchset: https://codereview.chromium.org/2288283002/#ps40001
(title: "cast_audio_only => is_cast_audio_only")

[commit-bot: I haz the power, 2016-08-29 22:28:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-30 03:41:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-30 03:41:42]

Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[wzhong, 2016-08-30 23:16:33]

lgtm

[slan, 2016-09-01 02:01:23]

There were several internal changes needed to support this, now ready to go.

[slan, 2016-09-01 02:01:39]

The CQ bit was checked by slan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-01 02:01:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-01 03:38:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-01 03:38:14]

Dry run: This issue passed the CQ dry run.

[slan, 2016-09-01 13:36:15]

The CQ bit was checked by slan@chromium.org

[commit-bot: I haz the power, 2016-09-01 13:36:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-01 13:40:37]

Description was changed from

==========
[Chromecast] Rename disable_display flag to is_cast_audio_only.

The disable_display flag is problematic in two ways:
 * It is not obviously Cast-specific from the name.
 * It is not named in the affirmative.

Fix these two problems by renaming this flag to is_cast_audio_only.

BUG=627641
==========

to

==========
[Chromecast] Rename disable_display flag to is_cast_audio_only.

The disable_display flag is problematic in two ways:
 * It is not obviously Cast-specific from the name.
 * It is not named in the affirmative.

Fix these two problems by renaming this flag to is_cast_audio_only.

BUG=627641
==========

[commit-bot: I haz the power, 2016-09-01 13:40:39]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-09-01 13:44:34]

Description was changed from

==========
[Chromecast] Rename disable_display flag to is_cast_audio_only.

The disable_display flag is problematic in two ways:
 * It is not obviously Cast-specific from the name.
 * It is not named in the affirmative.

Fix these two problems by renaming this flag to is_cast_audio_only.

BUG=627641
==========

to

==========
[Chromecast] Rename disable_display flag to is_cast_audio_only.

The disable_display flag is problematic in two ways:
 * It is not obviously Cast-specific from the name.
 * It is not named in the affirmative.

Fix these two problems by renaming this flag to is_cast_audio_only.

BUG=627641

Committed: https://crrev.com/a0671e41e14616132fcc8d2bde0c8349e15f334a
Cr-Commit-Position: refs/heads/master@{#415941}
==========

[commit-bot: I haz the power, 2016-09-01 13:44:36]

Patchset 3 (id:??) landed as
https://crrev.com/a0671e41e14616132fcc8d2bde0c8349e15f334a
Cr-Commit-Position: refs/heads/master@{#415941}