Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(489)

Side by Side Diff: build/config/chromecast_build.gni

Issue 2288283002: [Chromecast] Rename disable_display flag to is_cast_audio_only. (Closed)
Patch Set: cast_audio_only => is_cast_audio_only Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chromecast/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2015 The Chromium Authors. All rights reserved. 1 # Copyright 2015 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # The args declared in this file should be referenced by components outside of 5 # The args declared in this file should be referenced by components outside of
6 # //chromecast. Args needed only in //chromecast should be declared in 6 # //chromecast. Args needed only in //chromecast should be declared in
7 # //chromecast/chromecast.gni. 7 # //chromecast/chromecast.gni.
8 declare_args() { 8 declare_args() {
9 # Set this true for a Chromecast build. Chromecast builds are supported on 9 # Set this true for a Chromecast build. Chromecast builds are supported on
10 # Linux and Android. 10 # Linux and Android.
11 is_chromecast = false 11 is_chromecast = false
12 12
13 # Set this true for an audio-only Chromecast build. 13 # Set this true for an audio-only Chromecast build.
14 disable_display = false 14 is_cast_audio_only = false
15 } 15 }
16 16
17 # Note(slan): This arg depends on the value of is_chromecast, and thus must be 17 # Note(slan): This arg depends on the value of is_chromecast, and thus must be
18 # declared in a separate block. These blocks can be combined when/if 18 # declared in a separate block. These blocks can be combined when/if
19 # crbug.com/542846 is resolved. 19 # crbug.com/542846 is resolved.
20 declare_args() { 20 declare_args() {
21 # True if Chromecast build is targeted for linux desktop. This type of build 21 # True if Chromecast build is targeted for linux desktop. This type of build
22 # is useful for testing and development, but currently supports only a subset 22 # is useful for testing and development, but currently supports only a subset
23 # of Cast functionality. Though this defaults to true for x86 Linux devices, 23 # of Cast functionality. Though this defaults to true for x86 Linux devices,
24 # this should be overriden manually for an embedded x86 build. 24 # this should be overriden manually for an embedded x86 build.
25 # TODO(slan): Remove instances of this when x86 is a fully supported platform. 25 # TODO(slan): Remove instances of this when x86 is a fully supported platform.
26 is_cast_desktop_build = is_chromecast && target_os == "linux" && 26 is_cast_desktop_build = is_chromecast && target_os == "linux" &&
27 (target_cpu == "x86" || target_cpu == "x64") 27 (target_cpu == "x86" || target_cpu == "x64")
28 } 28 }
29 29
30 # Assert that Chromecast is being built for a supported platform. 30 # Assert that Chromecast is being built for a supported platform.
31 assert(is_linux || is_android || !is_chromecast, 31 assert(is_linux || is_android || !is_chromecast,
32 "Chromecast builds are not supported on $target_os") 32 "Chromecast builds are not supported on $target_os")
33 33
34 # Assert that disable_display and is_cast_desktop_build are both false on a 34 # Assert that is_cast_audio_only and is_cast_desktop_build are both false on a
35 # non-Chromecast build. 35 # non-Chromecast build.
36 assert(is_chromecast || !(disable_display || is_cast_desktop_build)) 36 assert(is_chromecast || (!is_cast_audio_only && !is_cast_desktop_build))
OLDNEW
« no previous file with comments | « no previous file | chromecast/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698