Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Issue 2288193002: Supress CHECK() in RawResourceClientStateChecker::responseReceived() (Closed)

Created:
4 years, 3 months ago by hiroshige
Modified:
4 years, 3 months ago
CC:
blink-reviews, chromium-reviews, gavinp+loader_chromium.org, Nate Chapin, loading-reviews+fetch_chromium.org, tyoshino+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Supress CHECK() in RawResourceClientStateChecker::responseReceived() This CL temporarily turns the SECURITY_CHECK() in RawResourceClientStateChecker::responseReceived() into SECURITY_DCHECK(), so that the check doesn't crash release builds and is potentially catched by tests or fuzzers while we are investigating the issue. BUG=640960, 640291 Committed: https://crrev.com/be7d5bee4161e753df168ead5fbbb44b4680f058 Cr-Commit-Position: refs/heads/master@{#415889}

Patch Set 1 #

Patch Set 2 : Use DCHECK #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M third_party/WebKit/Source/core/fetch/RawResource.cpp View 1 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 16 (9 generated)
hiroshige
PTAL. For context, see Issue 640960 (particularly Comments #1 and #8).
4 years, 3 months ago (2016-08-29 12:06:22 UTC) #3
yhirano
lgtm
4 years, 3 months ago (2016-08-29 12:26:33 UTC) #4
hiroshige
core/fetch OWNERs, could you take a look?
4 years, 3 months ago (2016-08-30 16:47:22 UTC) #9
Mike West
LGTM
4 years, 3 months ago (2016-08-31 13:18:19 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2288193002/20001
4 years, 3 months ago (2016-09-01 03:54:42 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-01 05:11:13 UTC) #14
commit-bot: I haz the power
4 years, 3 months ago (2016-09-01 05:13:20 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/be7d5bee4161e753df168ead5fbbb44b4680f058
Cr-Commit-Position: refs/heads/master@{#415889}

Powered by Google App Engine
This is Rietveld 408576698