third_party/WebKit/Source/core/fetch/RawResource.cpp - Issue 2288193002: Supress CHECK() in RawResourceClientStateChecker::responseReceived()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/fetch/RawResource.cpp

Issue 2288193002: Supress CHECK() in RawResourceClientStateChecker::responseReceived() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Use DCHECK Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/fetch/RawResource.cpp

diff --git a/third_party/WebKit/Source/core/fetch/RawResource.cpp b/third_party/WebKit/Source/core/fetch/RawResource.cpp

index a822dba21254ade52f53d079cef7960736f1ba74..698cc0dda42ec055a3455b3465588fbb452f6b9f 100644

--- a/third_party/WebKit/Source/core/fetch/RawResource.cpp

+++ b/third_party/WebKit/Source/core/fetch/RawResource.cpp

@@ -299,7 +299,9 @@ void RawResourceClientStateChecker::dataSent()

void RawResourceClientStateChecker::responseReceived()

{

- SECURITY_CHECK(m_state == Started);

+ // TODO(hiroshige): Temporarily we use DCHECK() here instead of CHECK(),

+ // due to crbug.com/640960.

+ SECURITY_DCHECK(m_state == Started);

m_state = ResponseReceived;

}

« no previous file with comments | « no previous file | no next file » | no next file with comments »