LayoutTests/fast/dom/XMLSerializer-doctype2.html - Issue 22880019: [DOM4] Doctypes now always have a node document and can be moved across document boundaries

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/fast/dom/XMLSerializer-doctype2.html

Issue 22880019: [DOM4] Doctypes now always have a node document and can be moved across document boundaries (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Add missing test Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/fast/dom/DOMImplementation/resources/createDocument-with-used-doctype-frame.html ('K') | « LayoutTests/fast/dom/DOMImplementation/resources/createDocument-with-used-doctype-frame.html ('k') | LayoutTests/fast/dom/XMLSerializer-doctype2-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/fast/dom/XMLSerializer-doctype2.html

diff --git a/LayoutTests/fast/dom/XMLSerializer-doctype2.html b/LayoutTests/fast/dom/XMLSerializer-doctype2.html

index 78da090c22a76f51424ac17ba4faa6907c4bcf1f..05ddc87dc698ac0ed6467455ae5c10cb307faabc 100644

--- a/LayoutTests/fast/dom/XMLSerializer-doctype2.html

+++ b/LayoutTests/fast/dom/XMLSerializer-doctype2.html

@@ -17,19 +17,16 @@

try {

var text = serializer.serializeToString(docType);

arv (Not doing code reviews) 2013/08/20 14:38:11 Maybe we should assert that the text is correct to

do-not-use 2013/08/20 15:31:00 Done.

- debug("FAIL: XMLSerializer.serializeToString() should throw an exception if it tries to serialize a documentless DocumentType node.");

+ debug("PASS: XMLSerializer.serializeToString() serialized the newly created DocumentType node without throwing.");

} catch (e) {

- if (e == "InvalidAccessError: A parameter or an operation was not supported by the underlying object.")

- debug("PASS: an " + e + " was thrown as expected.")

- else

- debug("FAIL: XMLSerializer.serializeToString() should throw an InvalidAccessError DOMExeption if it tries to serialize a documentless DocumentType node.");

+ debug("FAIL: an " + e + " was thrown as expected.")

}

</script>

</head>

arv (Not doing code reviews) 2013/08/20 14:38:11 no need to wait for onload

do-not-use 2013/08/20 15:31:00 Done.

-This tests XMLSerializer.serializeToString() on a DocumentType node that does not have a document associated

-with it. It should throw an INVALID_ACCESS_ERR DOMException.

+This tests XMLSerializer.serializeToString() on a newly created DocumentType node does not throw since the node has an

+associated document.

</ul>