LayoutTests/fast/dom/XMLSerializer-doctype2.html - Issue 22880019: [DOM4] Doctypes now always have a node document and can be moved across document boundaries

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/dom/XMLSerializer-doctype2.html

Issue 22880019: [DOM4] Doctypes now always have a node document and can be moved across document boundaries (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Add missing test Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« LayoutTests/fast/dom/DOMImplementation/resources/createDocument-with-used-doctype-frame.html ('K') | « LayoutTests/fast/dom/DOMImplementation/resources/createDocument-with-used-doctype-frame.html ('k') | LayoutTests/fast/dom/XMLSerializer-doctype2-expected.txt » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <html>	1 <html>

2 <head>	2 <head>

3 <script>	3 <script>

4 function debug(str) {	4 function debug(str) {

5 li = document.createElement('li');	5 li = document.createElement('li');

6 li.appendChild(document.createTextNode(str));	6 li.appendChild(document.createTextNode(str));

7 document.getElementById('console').appendChild(li);	7 document.getElementById('console').appendChild(li);

8 }	8 }

9	9

10 function runTests() {	10 function runTests() {

11 if (window.testRunner)	11 if (window.testRunner)

12 testRunner.dumpAsText();	12 testRunner.dumpAsText();

13	13

14 var docType = window.document.implementation.createDocumentType("aDo cTypeName", "aPublicID", "aSystemID");	14 var docType = window.document.implementation.createDocumentType("aDo cTypeName", "aPublicID", "aSystemID");

15	15

16 var serializer = new XMLSerializer();	16 var serializer = new XMLSerializer();

17	17

18 try {	18 try {

19 var text = serializer.serializeToString(docType);	19 var text = serializer.serializeToString(docType);
	arv (Not doing code reviews) 2013/08/20 14:38:11 Maybe we should assert that the text is correct to Maybe we should assert that the text is correct too? do-not-use 2013/08/20 15:31:00 Done. Show quoted text On 2013/08/20 14:38:11, arv wrote: > Maybe we should assert that the text is correct too? Done.
20 debug("FAIL: XMLSerializer.serializeToString() should throw an e xception if it tries to serialize a documentless DocumentType node.");	20 debug("PASS: XMLSerializer.serializeToString() serialized the ne wly created DocumentType node without throwing.");

21 } catch (e) {	21 } catch (e) {

22 if (e == "InvalidAccessError: A parameter or an operation was no t supported by the underlying object.")	22 debug("FAIL: an " + e + " was thrown as expected.")

23 debug("PASS: an " + e + " was thrown as expected.")

24 else

25 debug("FAIL: XMLSerializer.serializeToString() should throw an InvalidAccessError DOMExeption if it tries to serialize a documentless Docume ntType node.");

26 }	23 }

27 }	24 }

28 </script>	25 </script>

29 </head>	26 </head>

30 <body onload="runTests()">	27 <body onload="runTests()">
	arv (Not doing code reviews) 2013/08/20 14:38:11 no need to wait for onload no need to wait for onload do-not-use 2013/08/20 15:31:00 Done. Show quoted text On 2013/08/20 14:38:11, arv wrote: > no need to wait for onload Done.
31 This tests XMLSerializer.serializeToString() on a DocumentType node that does no t have a document associated	28 This tests XMLSerializer.serializeToString() on a newly created DocumentType nod e does not throw since the node has an

32 with it. It should throw an INVALID_ACCESS_ERR DOMException.	29 associated document.

33	30

34 <ul id="console">	31 <ul id="console">

35 </ul>	32 </ul>

36 </body>	33 </body>

37 </html>	34 </html>

OLD	NEW