Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 22880019: [DOM4] Doctypes now always have a node document and can be moved across document boundaries (Closed)

Created:
7 years, 4 months ago by do-not-use
Modified:
7 years, 4 months ago
CC:
blink-reviews, dglazkov+blink, eae+blinkwatch, adamk+blink_chromium.org
Visibility:
Public.

Description

[DOM4] Doctypes now always have a node document and can be moved across document boundaries Doctypes now always have a node document and can be moved across document boundaries as per the latest DOM4 specification: http://dom.spec.whatwg.org/#dom-domimplementation-createdocumenttype http://dom.spec.whatwg.org/#dom-node-ownerdocument This means that DOMImplementation.createDocumentType() now sets the ownerDocument of the new DocumentType Node to the associated document of the current "context" object. In DOM4, all nodes have a document at all times. DocumentType nodes can now be moved across document boundaries so that the node can be added to a Document after being created. Firefox stable already follows DOM4 here while IE10 does not (yet). BUG=275600 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=156581

Patch Set 1 #

Patch Set 2 : Add missing test #

Total comments: 7

Patch Set 3 : Improve tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+101 lines, -90 lines) Patch
M LayoutTests/fast/dom/DOMImplementation/createDocument-with-used-doctype.html View 1 2 2 chunks +5 lines, -17 lines 0 comments Download
M LayoutTests/fast/dom/DOMImplementation/createDocument-with-used-doctype-expected.txt View 1 2 1 chunk +16 lines, -1 line 0 comments Download
M LayoutTests/fast/dom/DOMImplementation/resources/createDocument-with-used-doctype-frame.html View 1 2 1 chunk +14 lines, -13 lines 0 comments Download
M LayoutTests/fast/dom/XMLSerializer-doctype2.html View 1 2 1 chunk +12 lines, -31 lines 0 comments Download
M LayoutTests/fast/dom/XMLSerializer-doctype2-expected.txt View 1 2 1 chunk +8 lines, -2 lines 0 comments Download
A LayoutTests/fast/dom/createDocumentType-ownerDocument.html View 1 1 chunk +20 lines, -0 lines 0 comments Download
A LayoutTests/fast/dom/createDocumentType-ownerDocument-expected.txt View 1 1 chunk +13 lines, -0 lines 0 comments Download
M LayoutTests/fast/dom/move-nodes-across-documents.html View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/dom/node-iterator-with-doctype-root.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/dom/node-iterator-with-doctype-root-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/events/dispatch-event-no-document.html View 2 chunks +4 lines, -4 lines 0 comments Download
M LayoutTests/fast/events/dispatch-event-no-document-expected.txt View 1 chunk +4 lines, -3 lines 0 comments Download
M Source/core/dom/ContainerNode.cpp View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
M Source/core/dom/DOMImplementation.cpp View 2 chunks +1 line, -11 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
do-not-use
7 years, 4 months ago (2013-08-19 14:45:46 UTC) #1
arv (Not doing code reviews)
LGTM https://codereview.chromium.org/22880019/diff/4001/LayoutTests/fast/dom/DOMImplementation/resources/createDocument-with-used-doctype-frame.html File LayoutTests/fast/dom/DOMImplementation/resources/createDocument-with-used-doctype-frame.html (right): https://codereview.chromium.org/22880019/diff/4001/LayoutTests/fast/dom/DOMImplementation/resources/createDocument-with-used-doctype-frame.html#newcode9 LayoutTests/fast/dom/DOMImplementation/resources/createDocument-with-used-doctype-frame.html:9: document.body.textContent = "PASS"; Are we moving (and adopting) ...
7 years, 4 months ago (2013-08-20 14:38:11 UTC) #2
do-not-use
https://codereview.chromium.org/22880019/diff/4001/LayoutTests/fast/dom/DOMImplementation/resources/createDocument-with-used-doctype-frame.html File LayoutTests/fast/dom/DOMImplementation/resources/createDocument-with-used-doctype-frame.html (right): https://codereview.chromium.org/22880019/diff/4001/LayoutTests/fast/dom/DOMImplementation/resources/createDocument-with-used-doctype-frame.html#newcode9 LayoutTests/fast/dom/DOMImplementation/resources/createDocument-with-used-doctype-frame.html:9: document.body.textContent = "PASS"; On 2013/08/20 14:38:11, arv wrote: > ...
7 years, 4 months ago (2013-08-20 15:00:38 UTC) #3
do-not-use
https://codereview.chromium.org/22880019/diff/4001/LayoutTests/fast/dom/DOMImplementation/resources/createDocument-with-used-doctype-frame.html File LayoutTests/fast/dom/DOMImplementation/resources/createDocument-with-used-doctype-frame.html (right): https://codereview.chromium.org/22880019/diff/4001/LayoutTests/fast/dom/DOMImplementation/resources/createDocument-with-used-doctype-frame.html#newcode9 LayoutTests/fast/dom/DOMImplementation/resources/createDocument-with-used-doctype-frame.html:9: document.body.textContent = "PASS"; On 2013/08/20 14:38:11, arv wrote: > ...
7 years, 4 months ago (2013-08-20 15:31:00 UTC) #4
arv (Not doing code reviews)
Thanks Still LGTM
7 years, 4 months ago (2013-08-20 16:45:09 UTC) #5
do-not-use
On 2013/08/20 16:45:09, arv wrote: > Thanks > > Still LGTM Thanks Erik. An API ...
7 years, 4 months ago (2013-08-20 19:49:30 UTC) #6
do-not-use
+abarth
7 years, 4 months ago (2013-08-22 05:51:44 UTC) #7
abarth-chromium
Great! LGTM. There's a bunch of code we can remove now that every Node has ...
7 years, 4 months ago (2013-08-22 19:35:15 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/22880019/12001
7 years, 4 months ago (2013-08-22 19:44:07 UTC) #9
commit-bot: I haz the power
7 years, 4 months ago (2013-08-22 22:09:43 UTC) #10
Message was sent while issue was closed. 
Change committed as 156581

Powered by Google App Engine
This is Rietveld 408576698