Chromium Code Reviews
|
|
Chromium Code Reviews|
Created:
4 years, 3 months ago by fs Modified:
4 years, 3 months ago Reviewers:
pdr. CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, krit, Eric Willigers, f(malita), gyuyoung2, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rjwright, rwlbuis, Stephen Chennney, shans Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionTighten SVGAnimationElement::shouldApplyAnimation
Fold the targetIsUsable(...) helper from SVGAnimateElement into said
method, and then replace the uses of the former with the corresponding
'should apply' predicate.
BUG=640676
Committed: https://crrev.com/fe3a12df154f8aa3d439f5ed275f0eb85ab2fc9a
Cr-Commit-Position: refs/heads/master@{#415253}
Patch Set 1 #
Created: 4 years, 3 months ago
Dependent Patchsets: Messages
Total messages: 21 (11 generated)
The CQ bit was checked by fs@opera.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
fs@opera.com changed reviewers: + pdr@chromium.org
Follow-up to suggestions from https://codereview.chromium.org/2285473002
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
On 2016/08/28 at 19:22:33, fs wrote: > Follow-up to suggestions from https://codereview.chromium.org/2285473002 The !parentNode() change is tricky but as far as I can tell correct (and cleaner now). LGTM
On 2016/08/29 at 00:38:54, pdr wrote: > On 2016/08/28 at 19:22:33, fs wrote: > > Follow-up to suggestions from https://codereview.chromium.org/2285473002 > > The !parentNode() change is tricky but as far as I can tell correct (and cleaner now). ...and quite possibly redundant =)
The CQ bit was checked by fs@opera.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by fs@opera.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...) win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was checked by fs@opera.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Tighten SVGAnimationElement::shouldApplyAnimation Fold the targetIsUsable(...) helper from SVGAnimateElement into said method, and then replace the uses of the former with the corresponding 'should apply' predicate. BUG=640676 ========== to ========== Tighten SVGAnimationElement::shouldApplyAnimation Fold the targetIsUsable(...) helper from SVGAnimateElement into said method, and then replace the uses of the former with the corresponding 'should apply' predicate. BUG=640676 Committed: https://crrev.com/fe3a12df154f8aa3d439f5ed275f0eb85ab2fc9a Cr-Commit-Position: refs/heads/master@{#415253} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/fe3a12df154f8aa3d439f5ed275f0eb85ab2fc9a Cr-Commit-Position: refs/heads/master@{#415253} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
