Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(541)

Issue 2287983002: Tighten SVGAnimationElement::shouldApplyAnimation (Closed)

Created:
4 years, 3 months ago by fs
Modified:
4 years, 3 months ago
Reviewers:
pdr.
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, krit, Eric Willigers, f(malita), gyuyoung2, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rjwright, rwlbuis, Stephen Chennney, shans
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Tighten SVGAnimationElement::shouldApplyAnimation Fold the targetIsUsable(...) helper from SVGAnimateElement into said method, and then replace the uses of the former with the corresponding 'should apply' predicate. BUG=640676 Committed: https://crrev.com/fe3a12df154f8aa3d439f5ed275f0eb85ab2fc9a Cr-Commit-Position: refs/heads/master@{#415253}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -12 lines) Patch
M third_party/WebKit/Source/core/svg/SVGAnimateElement.cpp View 5 chunks +3 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGAnimationElement.cpp View 1 chunk +5 lines, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 21 (11 generated)
fs
Follow-up to suggestions from https://codereview.chromium.org/2285473002
4 years, 3 months ago (2016-08-28 19:22:33 UTC) #4
pdr.
On 2016/08/28 at 19:22:33, fs wrote: > Follow-up to suggestions from https://codereview.chromium.org/2285473002 The !parentNode() change ...
4 years, 3 months ago (2016-08-29 00:38:54 UTC) #7
fs
On 2016/08/29 at 00:38:54, pdr wrote: > On 2016/08/28 at 19:22:33, fs wrote: > > ...
4 years, 3 months ago (2016-08-29 08:15:27 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2287983002/1
4 years, 3 months ago (2016-08-29 08:15:59 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/131789)
4 years, 3 months ago (2016-08-29 09:33:19 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2287983002/1
4 years, 3 months ago (2016-08-29 17:52:20 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/286802) win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, ...
4 years, 3 months ago (2016-08-30 03:41:37 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2287983002/1
4 years, 3 months ago (2016-08-30 07:54:44 UTC) #18
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-30 09:21:04 UTC) #19
commit-bot: I haz the power
4 years, 3 months ago (2016-08-30 09:22:19 UTC) #21
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fe3a12df154f8aa3d439f5ed275f0eb85ab2fc9a
Cr-Commit-Position: refs/heads/master@{#415253}

Powered by Google App Engine
This is Rietveld 408576698