Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Issue 2284263002: Simplify SVGAnimatedTypeAnimator interface (Closed)

Created:
4 years, 3 months ago by fs
Modified:
4 years, 3 months ago
Reviewers:
pdr.
CC:
fs, darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, krit, Eric Willigers, f(malita), gyuyoung2, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rjwright, rwlbuis, Stephen Chennney, shans
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Simplify SVGAnimatedTypeAnimator interface The two methods startAnimValAnimation and resetAnimValToBaseVal share the same implementation, but are called in two different branches of the same if-statement. Fold the two and add a new method createAnimatedValue() to provide the animated value, to make this appear as straight-forward as it is. Also fold the stopAnimValAnimation() method since it's only used once, and because this makes the start/stop action somewhat symmetric. Rename the constructFromString(...) method to createAnimatedValueFromString() to illustrate its relation to the newly minted method and make it a bit more clear what it does. BUG=640676 Committed: https://crrev.com/2e7202542f73e6a411d0c1808e2112a150254e3b Cr-Commit-Position: refs/heads/master@{#415271}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -40 lines) Patch
M third_party/WebKit/Source/core/svg/SVGAnimateElement.cpp View 4 chunks +5 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGAnimatedTypeAnimator.h View 2 chunks +2 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGAnimatedTypeAnimator.cpp View 1 chunk +6 lines, -26 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 15 (9 generated)
fs
4 years, 3 months ago (2016-08-28 20:57:57 UTC) #6
pdr.
On 2016/08/28 at 20:57:57, fs wrote: > LGTM
4 years, 3 months ago (2016-08-29 00:22:28 UTC) #7
commit-bot: I haz the power
This CL has an open dependency (Issue 2287983002 Patch 1). Please resolve the dependency and ...
4 years, 3 months ago (2016-08-29 08:13:26 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2284263002/1
4 years, 3 months ago (2016-08-30 09:34:54 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-30 11:31:16 UTC) #13
commit-bot: I haz the power
4 years, 3 months ago (2016-08-30 11:33:19 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2e7202542f73e6a411d0c1808e2112a150254e3b
Cr-Commit-Position: refs/heads/master@{#415271}

Powered by Google App Engine
This is Rietveld 408576698