components/favicon.gypi - Issue 228783002: Moves knowledge of Profile out of FaviconHandler, into FaviconTabHelper.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/favicon.gypi

Issue 228783002: Moves knowledge of Profile out of FaviconHandler, into FaviconTabHelper. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@FAVICON_3

Patch Set: Rebase. Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/favicon.gypi

diff --git a/components/favicon.gypi b/components/favicon.gypi

index 32ec54b6046f2f8301bb3a8caf430eecb1d3fb75..9a67335d7ec339ba7f0ba7ff24356e0d9a96af3a 100644

--- a/components/favicon.gypi

+++ b/components/favicon.gypi

@@ -8,6 +8,7 @@

'target_name': 'favicon_core',

'type': 'none',

'sources': [

+ 'favicon/core/browser/favicon_client.h',

'favicon/core/favicon_handler_delegate.h',

« no previous file with comments | « chrome/browser/favicon/favicon_tab_helper.cc ('k') | components/favicon/core/browser/favicon_client.h » ('j') | no next file with comments »