components/favicon.gypi - Issue 228783002: Moves knowledge of Profile out of FaviconHandler, into FaviconTabHelper.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/favicon.gypi

Issue 228783002: Moves knowledge of Profile out of FaviconHandler, into FaviconTabHelper. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@FAVICON_3

Patch Set: Rebase. Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 # Copyright 2014 The Chromium Authors. All rights reserved.	1 # Copyright 2014 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 {	5 {

6 'targets': [	6 'targets': [

7 {	7 {

8 'target_name': 'favicon_core',	8 'target_name': 'favicon_core',

9 'type': 'none',	9 'type': 'none',

10 'sources': [	10 'sources': [

	11 'favicon/core/browser/favicon_client.h',

11 'favicon/core/favicon_handler_delegate.h',	12 'favicon/core/favicon_handler_delegate.h',

12 ],	13 ],

13 },	14 },

14 ],	15 ],

15 }	16 }

OLD	NEW

« no previous file with comments | « chrome/browser/favicon/favicon_tab_helper.cc ('k') | components/favicon/core/browser/favicon_client.h » ('j') | no next file with comments »