Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 2287813002: Remove OnThemeChanged and associated unused message (Closed)

Created:
4 years, 3 months ago by scottmg
Modified:
4 years, 3 months ago
Reviewers:
jschuh, jam, Will Harris
CC:
chromium-reviews, jam, nasko+codewatch_chromium.org, darin-cc_chromium.org, creis+watch_chromium.org, mlamouri+watch-content_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove OnThemeChanged and associated ViewMsg_ThemeChanged ViewMsg_ThemeChanged was never sent, and even if it was, the only code path that did anything was #if USE_AURA // nothing #elif OS_WIN // do stuff ... so it was never going to run. Noticed while trying to clean up NativeThemeWin usage from Blink, which also makes little-to-no sense and causes the linked bug. R=jam@chromium.org BUG=258201 Committed: https://crrev.com/41dca1f3e19cc520750eee94f11d4e8332cd16b3 Cr-Commit-Position: refs/heads/master@{#415371}

Patch Set 1 #

Patch Set 2 : linux too #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -24 lines) Patch
M content/common/view_messages.h View 1 chunk +0 lines, -3 lines 0 comments Download
M content/renderer/render_view_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/render_view_impl.cc View 1 3 chunks +0 lines, -20 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 32 (20 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2287813002/1
4 years, 3 months ago (2016-08-27 04:04:48 UTC) #7
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 3 months ago (2016-08-27 04:04:49 UTC) #9
scottmg
4 years, 3 months ago (2016-08-28 02:21:28 UTC) #14
jam
lgtm
4 years, 3 months ago (2016-08-30 16:34:40 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2287813002/40001
4 years, 3 months ago (2016-08-30 16:35:36 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/249286)
4 years, 3 months ago (2016-08-30 16:41:24 UTC) #21
scottmg
+jschuh for content/common/view_messages.h removal.
4 years, 3 months ago (2016-08-30 17:10:52 UTC) #23
scottmg
how about +wfh for a trivial stamp for view_messages.h?
4 years, 3 months ago (2016-08-30 18:30:41 UTC) #25
Will Harris
trivial rs lgtm
4 years, 3 months ago (2016-08-30 18:35:54 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2287813002/40001
4 years, 3 months ago (2016-08-30 18:39:46 UTC) #28
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 3 months ago (2016-08-30 18:46:29 UTC) #30
commit-bot: I haz the power
4 years, 3 months ago (2016-08-30 18:49:17 UTC) #32
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/41dca1f3e19cc520750eee94f11d4e8332cd16b3
Cr-Commit-Position: refs/heads/master@{#415371}

Powered by Google App Engine
This is Rietveld 408576698