|
|
DescriptionRemove OnThemeChanged and associated ViewMsg_ThemeChanged
ViewMsg_ThemeChanged was never sent, and even if it was, the only code
path that did anything was
#if USE_AURA
// nothing
#elif OS_WIN
// do stuff
...
so it was never going to run. Noticed while trying to clean up
NativeThemeWin usage from Blink, which also makes little-to-no sense and
causes the linked bug.
R=jam@chromium.org
BUG=258201
Committed: https://crrev.com/41dca1f3e19cc520750eee94f11d4e8332cd16b3
Cr-Commit-Position: refs/heads/master@{#415371}
Patch Set 1 #Patch Set 2 : linux too #Patch Set 3 : rebase #
Dependent Patchsets: Messages
Total messages: 32 (20 generated)
The CQ bit was checked by scottmg@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Remove OnThemeChanged and associated ViewMsg_ThemeChanged ViewMsg_ThemeChanged was never sent, and even if it was, the only code path that did anything was // nothing // do stuff ... so it was never going to run. Noticed while trying to clean up NativeThemeWin usage from Blink, which also makes little-to-no sense and causes the linked bug. R=jam@chromium.org BUG=258201 ========== to ========== Remove OnThemeChanged and associated ViewMsg_ThemeChanged ViewMsg_ThemeChanged was never sent, and even if it was, the only code path that did anything was #if USE_AURA // nothing #elif OS_WIN // do stuff ... so it was never going to run. Noticed while trying to clean up NativeThemeWin usage from Blink, which also makes little-to-no sense and causes the linked bug. R=jam@chromium.org BUG=258201 ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was checked by scottmg@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
The CQ bit was checked by scottmg@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by scottmg@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm
The CQ bit was checked by scottmg@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
scottmg@chromium.org changed reviewers: + jschuh@chromium.org
+jschuh for content/common/view_messages.h removal.
scottmg@chromium.org changed reviewers: + wfh@chromium.org
how about +wfh for a trivial stamp for view_messages.h?
trivial rs lgtm
The CQ bit was checked by scottmg@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Remove OnThemeChanged and associated ViewMsg_ThemeChanged ViewMsg_ThemeChanged was never sent, and even if it was, the only code path that did anything was #if USE_AURA // nothing #elif OS_WIN // do stuff ... so it was never going to run. Noticed while trying to clean up NativeThemeWin usage from Blink, which also makes little-to-no sense and causes the linked bug. R=jam@chromium.org BUG=258201 ========== to ========== Remove OnThemeChanged and associated ViewMsg_ThemeChanged ViewMsg_ThemeChanged was never sent, and even if it was, the only code path that did anything was #if USE_AURA // nothing #elif OS_WIN // do stuff ... so it was never going to run. Noticed while trying to clean up NativeThemeWin usage from Blink, which also makes little-to-no sense and causes the linked bug. R=jam@chromium.org BUG=258201 ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Remove OnThemeChanged and associated ViewMsg_ThemeChanged ViewMsg_ThemeChanged was never sent, and even if it was, the only code path that did anything was #if USE_AURA // nothing #elif OS_WIN // do stuff ... so it was never going to run. Noticed while trying to clean up NativeThemeWin usage from Blink, which also makes little-to-no sense and causes the linked bug. R=jam@chromium.org BUG=258201 ========== to ========== Remove OnThemeChanged and associated ViewMsg_ThemeChanged ViewMsg_ThemeChanged was never sent, and even if it was, the only code path that did anything was #if USE_AURA // nothing #elif OS_WIN // do stuff ... so it was never going to run. Noticed while trying to clean up NativeThemeWin usage from Blink, which also makes little-to-no sense and causes the linked bug. R=jam@chromium.org BUG=258201 Committed: https://crrev.com/41dca1f3e19cc520750eee94f11d4e8332cd16b3 Cr-Commit-Position: refs/heads/master@{#415371} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/41dca1f3e19cc520750eee94f11d4e8332cd16b3 Cr-Commit-Position: refs/heads/master@{#415371} |