Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2290743002:
Partial revert of https://codereview.chromium.org/1911973002/ (Closed)
|
Created:
4 years, 3 months ago by scottmg Modified:
4 years, 3 months ago CC:
ananta, Bret, chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, jam, mlamouri+watch-content_chromium.org, nasko+codewatch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionPartial revert of https://codereview.chromium.org/1911973002/
This avoids calling NativeThemeWin methods in the renderer, which call
user32, gdi32, and load uxtheme.dll, which we don't/can't do in the
renderer.
Also removes native_theme_win and native_theme_dark_win from child
processes at the build file level. There's no way they could work in the
renderer implemented as they are. NativeThemeAuraWin is removed as it
was only used to special case scrollbars to NativeThemeWin, but that
doesn't work.
Attempted to readd a DLOG(FATAL) to SingletonHwnd(), but can't yet for
a different reason, browser_tests:
[3472:4712:0829/151623:FATAL:singleton_hwnd.cc(34)] Cannot create windows on non-UI thread!
Backtrace:
base::debug::StackTrace::StackTrace [0x023E3157+23]
logging::LogMessage::~LogMessage [0x0239A681+49]
gfx::SingletonHwnd::SingletonHwnd [0x02EA5A6E+111]
base::Singleton<gfx::SingletonHwnd,base::DefaultSingletonTraits<gfx::SingletonHwnd>,gfx::SingletonHwnd>::get [0x02EA5BCB+42]
gfx::GetFontRenderParams [0x02E97CED+344]
gfx::GetFontRenderParams [0x02E97BF6+97]
content::PpapiPluginMain [0x02304622+390]
...
BUG=258201
Committed: https://crrev.com/b92365ec08b7d2e96974df794dfb7a7f1ac347c8
Cr-Commit-Position: refs/heads/master@{#415420}
Patch Set 1 #Patch Set 2 : . #
Total comments: 2
Patch Set 3 : comment in header #
Total comments: 1
Patch Set 4 : no fatal yet :( #Patch Set 5 : mac libtool #
Messages
Total messages: 59 (36 generated)
The CQ bit was checked by scottmg@chromium.org to run a CQ dry run
Description was changed from ========== Partial revert of https://codereview.chromium.org/1911973002/ and ... make non-UI thread SingletonHwnd creation fatal. R= BUG=258201 ========== to ========== Partial revert of https://codereview.chromium.org/1911973002/ and ... make non-UI thread SingletonHwnd creation fatal. R=bsep@chromium.org, ananta@chromium.org BUG=258201 ==========
scottmg@chromium.org changed reviewers: + ananta@chromium.org, bsep@chromium.org
Description was changed from ========== Partial revert of https://codereview.chromium.org/1911973002/ and ... make non-UI thread SingletonHwnd creation fatal. R=bsep@chromium.org, ananta@chromium.org BUG=258201 ========== to ========== Partial revert of https://codereview.chromium.org/1911973002/ and ... make non-UI thread SingletonHwnd creation fatal. This avoids calling NativeThemeWin methods in the renderer R=bsep@chromium.org, ananta@chromium.org BUG=258201 ==========
Description was changed from ========== Partial revert of https://codereview.chromium.org/1911973002/ and ... make non-UI thread SingletonHwnd creation fatal. This avoids calling NativeThemeWin methods in the renderer R=bsep@chromium.org, ananta@chromium.org BUG=258201 ========== to ========== Partial revert of https://codereview.chromium.org/1911973002/ and ... make non-UI thread SingletonHwnd creation fatal. This avoids calling NativeThemeWin methods in the renderer, which call user32, gdi32, and load uxtheme.dll, which we don't/can't do in the renderer. Also switch a previous DLOG(ERROR) to FATAL to notice future regressions. We should also investigate if we can remove native_theme_win entirely from the child process. I'm not sure if that's possible or not, but it's a bit hokey at the moment. R=bsep@chromium.org, ananta@chromium.org BUG=258201 ==========
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Partial revert of https://codereview.chromium.org/1911973002/ and ... make non-UI thread SingletonHwnd creation fatal. This avoids calling NativeThemeWin methods in the renderer, which call user32, gdi32, and load uxtheme.dll, which we don't/can't do in the renderer. Also switch a previous DLOG(ERROR) to FATAL to notice future regressions. We should also investigate if we can remove native_theme_win entirely from the child process. I'm not sure if that's possible or not, but it's a bit hokey at the moment. R=bsep@chromium.org, ananta@chromium.org BUG=258201 ========== to ========== Partial revert of https://codereview.chromium.org/1911973002/ and ... make non-UI thread SingletonHwnd creation fatal. This avoids calling NativeThemeWin methods in the renderer, which call user32, gdi32, and load uxtheme.dll, which we don't/can't do in the renderer. Also switch a previous DLOG(ERROR) to FATAL to notice future regressions. Also removes native_theme_win and native_theme_dark_win from child processes at the build file level. There's no way they could work in the renderer implemented as they are. NativeThemAuraWin is removed as it was only used to scrollbars to NativeThemeWin, but that doesn't work. R=bsep@chromium.org, ananta@chromium.org BUG=258201 ==========
The CQ bit was checked by scottmg@chromium.org to run a CQ dry run
Description was changed from ========== Partial revert of https://codereview.chromium.org/1911973002/ and ... make non-UI thread SingletonHwnd creation fatal. This avoids calling NativeThemeWin methods in the renderer, which call user32, gdi32, and load uxtheme.dll, which we don't/can't do in the renderer. Also switch a previous DLOG(ERROR) to FATAL to notice future regressions. Also removes native_theme_win and native_theme_dark_win from child processes at the build file level. There's no way they could work in the renderer implemented as they are. NativeThemAuraWin is removed as it was only used to scrollbars to NativeThemeWin, but that doesn't work. R=bsep@chromium.org, ananta@chromium.org BUG=258201 ========== to ========== Partial revert of https://codereview.chromium.org/1911973002/ and ... make non-UI thread SingletonHwnd creation fatal. This avoids calling NativeThemeWin methods in the renderer, which call user32, gdi32, and load uxtheme.dll, which we don't/can't do in the renderer. Also switch a previous DLOG(ERROR) to FATAL to notice future regressions. Also removes native_theme_win and native_theme_dark_win from child processes at the build file level. There's no way they could work in the renderer implemented as they are. NativeThemeAuraWin is removed as it was only used to scrollbars to NativeThemeWin, but that doesn't work. R=bsep@chromium.org, ananta@chromium.org BUG=258201 ==========
Description was changed from ========== Partial revert of https://codereview.chromium.org/1911973002/ and ... make non-UI thread SingletonHwnd creation fatal. This avoids calling NativeThemeWin methods in the renderer, which call user32, gdi32, and load uxtheme.dll, which we don't/can't do in the renderer. Also switch a previous DLOG(ERROR) to FATAL to notice future regressions. Also removes native_theme_win and native_theme_dark_win from child processes at the build file level. There's no way they could work in the renderer implemented as they are. NativeThemeAuraWin is removed as it was only used to scrollbars to NativeThemeWin, but that doesn't work. R=bsep@chromium.org, ananta@chromium.org BUG=258201 ========== to ========== Partial revert of https://codereview.chromium.org/1911973002/ and ... make non-UI thread SingletonHwnd creation fatal. This avoids calling NativeThemeWin methods in the renderer, which call user32, gdi32, and load uxtheme.dll, which we don't/can't do in the renderer. Also switch a previous DLOG(ERROR) to FATAL to notice future regressions. Also removes native_theme_win and native_theme_dark_win from child processes at the build file level. There's no way they could work in the renderer implemented as they are. NativeThemeAuraWin is removed as it was only used to scrollbars to NativeThemeWin, but that doesn't work. R=bsep@chromium.org, ananta@chromium.org BUG=258201 ==========
scottmg@chromium.org changed reviewers: + esprehn@chromium.org, estade@chromium.org - ananta@chromium.org, bsep@chromium.org
Description was changed from ========== Partial revert of https://codereview.chromium.org/1911973002/ and ... make non-UI thread SingletonHwnd creation fatal. This avoids calling NativeThemeWin methods in the renderer, which call user32, gdi32, and load uxtheme.dll, which we don't/can't do in the renderer. Also switch a previous DLOG(ERROR) to FATAL to notice future regressions. Also removes native_theme_win and native_theme_dark_win from child processes at the build file level. There's no way they could work in the renderer implemented as they are. NativeThemeAuraWin is removed as it was only used to scrollbars to NativeThemeWin, but that doesn't work. R=bsep@chromium.org, ananta@chromium.org BUG=258201 ========== to ========== Partial revert of https://codereview.chromium.org/1911973002/ and ... make non-UI thread SingletonHwnd creation fatal. This avoids calling NativeThemeWin methods in the renderer, which call user32, gdi32, and load uxtheme.dll, which we don't/can't do in the renderer. Also switch a previous DLOG(ERROR) to FATAL to notice future regressions. Also removes native_theme_win and native_theme_dark_win from child processes at the build file level. There's no way they could work in the renderer implemented as they are. NativeThemeAuraWin is removed as it was only used to scrollbars to NativeThemeWin, but that doesn't work. BUG=258201 ==========
The CQ bit was checked by scottmg@chromium.org to run a CQ dry run
The chrome/ and content/ files are a revert of https://codereview.chromium.org/1911973002/ so +esprehn and +estade as original reviewers for that. The scrollbar sizes need to be passed through from the browser via RendererPreferences because the sandboxed renderer cannot request them from the system in the renderer, which is what used to happen. ui/native_theme also for estade -- removing native_theme_win from child processes entirely because it was very confusing, and it should only be using Aura code there anyway.
Your change description says "..." what should be there?
Description was changed from ========== Partial revert of https://codereview.chromium.org/1911973002/ and ... make non-UI thread SingletonHwnd creation fatal. This avoids calling NativeThemeWin methods in the renderer, which call user32, gdi32, and load uxtheme.dll, which we don't/can't do in the renderer. Also switch a previous DLOG(ERROR) to FATAL to notice future regressions. Also removes native_theme_win and native_theme_dark_win from child processes at the build file level. There's no way they could work in the renderer implemented as they are. NativeThemeAuraWin is removed as it was only used to scrollbars to NativeThemeWin, but that doesn't work. BUG=258201 ========== to ========== Partial revert of https://codereview.chromium.org/1911973002/ and make non-UI thread SingletonHwnd creation fatal. This avoids calling NativeThemeWin methods in the renderer, which call user32, gdi32, and load uxtheme.dll, which we don't/can't do in the renderer. Also switch a previous DLOG(ERROR) to FATAL to notice future regressions. Also removes native_theme_win and native_theme_dark_win from child processes at the build file level. There's no way they could work in the renderer implemented as they are. NativeThemeAuraWin is removed as it was only used to scrollbars to NativeThemeWin, but that doesn't work. BUG=258201 ==========
On 2016/08/29 20:18:04, esprehn wrote: > Your change description says "..." what should be there? Some people get antsy in git if it exceeds 72 col. Unwrapped from previous line.
On 2016/08/29 20:19:55, scottmg wrote: > On 2016/08/29 20:18:04, esprehn wrote: > > Your change description says "..." what should be there? > > Some people get antsy in git if it exceeds 72 col. Unwrapped from previous line. Er, *next* line. :/
So this preserves the feature, but it never worked... so how did the original author test this?
Description was changed from ========== Partial revert of https://codereview.chromium.org/1911973002/ and make non-UI thread SingletonHwnd creation fatal. This avoids calling NativeThemeWin methods in the renderer, which call user32, gdi32, and load uxtheme.dll, which we don't/can't do in the renderer. Also switch a previous DLOG(ERROR) to FATAL to notice future regressions. Also removes native_theme_win and native_theme_dark_win from child processes at the build file level. There's no way they could work in the renderer implemented as they are. NativeThemeAuraWin is removed as it was only used to scrollbars to NativeThemeWin, but that doesn't work. BUG=258201 ========== to ========== Partial revert of https://codereview.chromium.org/1911973002/ and make non-UI thread SingletonHwnd creation fatal. This avoids calling NativeThemeWin methods in the renderer, which call user32, gdi32, and load uxtheme.dll, which we don't/can't do in the renderer. Also switch a previous DLOG(ERROR) to FATAL to notice future regressions. Also removes native_theme_win and native_theme_dark_win from child processes at the build file level. There's no way they could work in the renderer implemented as they are. NativeThemeAuraWin is removed as it was only used to scrollbars to NativeThemeWin, but that doesn't work. BUG=258201 ==========
On 2016/08/29 20:20:11, esprehn wrote: > So this preserves the feature, but it never worked... so how did the original > author test this? The unreverted remained of https://codereview.chromium.org/1911973002/ improved arrow drawing. I'm not reverting that part here. My understanding is that was somewhat unrelated cleanup as the plumbing was thought to be unnecessary. The (sorta) feature I'm trying to achieve is that we don't try to create windows in the renderer (the linked bug), which is achieved by the LOG(FATAL) and by removing the most common offender (NativeThemeWin) from the renderer entirely at the build file level.
estade@chromium.org changed reviewers: + bsep@chromium.org
+bsep https://codereview.chromium.org/2290743002/diff/20001/content/child/webthemee... File content/child/webthemeengine_impl_default.h (right): https://codereview.chromium.org/2290743002/diff/20001/content/child/webthemee... content/child/webthemeengine_impl_default.h:31: // Caches the scrollbar metrics. is it explained somewhere why this is necessary? Your CL description is very helpful but it doesn't seem obvious from looking at the code why there's this extra windows hoopla.
https://codereview.chromium.org/2290743002/diff/20001/content/child/webthemee... File content/child/webthemeengine_impl_default.h (right): https://codereview.chromium.org/2290743002/diff/20001/content/child/webthemee... content/child/webthemeengine_impl_default.h:31: // Caches the scrollbar metrics. On 2016/08/29 20:40:35, Evan Stade wrote: > is it explained somewhere why this is necessary? Your CL description is very > helpful but it doesn't seem obvious from looking at the code why there's this > extra windows hoopla. Expanded on the comment here.
scottmg@chromium.org changed reviewers: + thakis@chromium.org
oh, and +thakis for ui/gfx/win/singleton_hwnd.cc owners.
Description was changed from ========== Partial revert of https://codereview.chromium.org/1911973002/ and make non-UI thread SingletonHwnd creation fatal. This avoids calling NativeThemeWin methods in the renderer, which call user32, gdi32, and load uxtheme.dll, which we don't/can't do in the renderer. Also switch a previous DLOG(ERROR) to FATAL to notice future regressions. Also removes native_theme_win and native_theme_dark_win from child processes at the build file level. There's no way they could work in the renderer implemented as they are. NativeThemeAuraWin is removed as it was only used to scrollbars to NativeThemeWin, but that doesn't work. BUG=258201 ========== to ========== Partial revert of https://codereview.chromium.org/1911973002/ and make non-UI thread SingletonHwnd creation fatal. This avoids calling NativeThemeWin methods in the renderer, which call user32, gdi32, and load uxtheme.dll, which we don't/can't do in the renderer. Also switch a previous DLOG(ERROR) to FATAL to notice future regressions. Also removes native_theme_win and native_theme_dark_win from child processes at the build file level. There's no way they could work in the renderer implemented as they are. NativeThemeAuraWin is removed as it was only used to special case scrollbars to NativeThemeWin, but that doesn't work. BUG=258201 ==========
lgtm
my file lgtm https://codereview.chromium.org/2290743002/diff/40001/ui/gfx/win/singleton_hw... File ui/gfx/win/singleton_hwnd.cc (right): https://codereview.chromium.org/2290743002/diff/40001/ui/gfx/win/singleton_hw... ui/gfx/win/singleton_hwnd.cc:34: LOG(FATAL) << "Cannot create windows on non-UI thread!"; \o/
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by scottmg@chromium.org to run a CQ dry run
lgtm
lgtm
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Thanks all for the quick reviews.
Description was changed from ========== Partial revert of https://codereview.chromium.org/1911973002/ and make non-UI thread SingletonHwnd creation fatal. This avoids calling NativeThemeWin methods in the renderer, which call user32, gdi32, and load uxtheme.dll, which we don't/can't do in the renderer. Also switch a previous DLOG(ERROR) to FATAL to notice future regressions. Also removes native_theme_win and native_theme_dark_win from child processes at the build file level. There's no way they could work in the renderer implemented as they are. NativeThemeAuraWin is removed as it was only used to special case scrollbars to NativeThemeWin, but that doesn't work. BUG=258201 ========== to ========== Partial revert of https://codereview.chromium.org/1911973002/ and make non-UI thread SingletonHwnd creation fatal. This avoids calling NativeThemeWin methods in the renderer, which call user32, gdi32, and load uxtheme.dll, which we don't/can't do in the renderer. Also switch a previous DLOG(ERROR) to FATAL to notice future regressions. Also removes native_theme_win and native_theme_dark_win from child processes at the build file level. There's no way they could work in the renderer implemented as they are. NativeThemeAuraWin is removed as it was only used to special case scrollbars to NativeThemeWin, but that doesn't work. BUG=258201 NO_DEPENDENCY_CHECKS=true ==========
The CQ bit was unchecked by scottmg@chromium.org
The CQ bit was checked by scottmg@chromium.org
CQ says
"""
Missing LGTM from an OWNER for these files:
content/common/view_messages.h
"""
... I have absolutely no idea where it got that from.
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Patchset #4 (id:60001) has been deleted
On 2016/08/29 22:28:14, scottmg wrote: > CQ says > > """ > Missing LGTM from an OWNER for these files: > content/common/view_messages.h > """ > > ... I have absolutely no idea where it got that from. I think it's probably because I changed the file in a dependent patch set. But it's not mentioned in the diff at all, so I think the CQ is confused. Filed https://bugs.chromium.org/p/chromium/issues/detail?id=642166.
Patchset #4 (id:80001) has been deleted
Description was changed from ========== Partial revert of https://codereview.chromium.org/1911973002/ and make non-UI thread SingletonHwnd creation fatal. This avoids calling NativeThemeWin methods in the renderer, which call user32, gdi32, and load uxtheme.dll, which we don't/can't do in the renderer. Also switch a previous DLOG(ERROR) to FATAL to notice future regressions. Also removes native_theme_win and native_theme_dark_win from child processes at the build file level. There's no way they could work in the renderer implemented as they are. NativeThemeAuraWin is removed as it was only used to special case scrollbars to NativeThemeWin, but that doesn't work. BUG=258201 NO_DEPENDENCY_CHECKS=true ========== to ========== Partial revert of https://codereview.chromium.org/1911973002/ This avoids calling NativeThemeWin methods in the renderer, which call user32, gdi32, and load uxtheme.dll, which we don't/can't do in the renderer. Also removes native_theme_win and native_theme_dark_win from child processes at the build file level. There's no way they could work in the renderer implemented as they are. NativeThemeAuraWin is removed as it was only used to special case scrollbars to NativeThemeWin, but that doesn't work. BUG=258201 NO_DEPENDENCY_CHECKS=true ==========
Description was changed from ========== Partial revert of https://codereview.chromium.org/1911973002/ This avoids calling NativeThemeWin methods in the renderer, which call user32, gdi32, and load uxtheme.dll, which we don't/can't do in the renderer. Also removes native_theme_win and native_theme_dark_win from child processes at the build file level. There's no way they could work in the renderer implemented as they are. NativeThemeAuraWin is removed as it was only used to special case scrollbars to NativeThemeWin, but that doesn't work. BUG=258201 NO_DEPENDENCY_CHECKS=true ========== to ========== Partial revert of https://codereview.chromium.org/1911973002/ This avoids calling NativeThemeWin methods in the renderer, which call user32, gdi32, and load uxtheme.dll, which we don't/can't do in the renderer. Also removes native_theme_win and native_theme_dark_win from child processes at the build file level. There's no way they could work in the renderer implemented as they are. NativeThemeAuraWin is removed as it was only used to special case scrollbars to NativeThemeWin, but that doesn't work. Attempted to readd a DLOG(FATAL) to SingletonHwnd(), but can't yet for a different reason, browser_tests: [3472:4712:0829/151623:FATAL:singleton_hwnd.cc(34)] Cannot create windows on non-UI thread! Backtrace: base::debug::StackTrace::StackTrace [0x023E3157+23] logging::LogMessage::~LogMessage [0x0239A681+49] gfx::SingletonHwnd::SingletonHwnd [0x02EA5A6E+111] base::Singleton<gfx::SingletonHwnd,base::DefaultSingletonTraits<gfx::SingletonHwnd>,gfx::SingletonHwnd>::get [0x02EA5BCB+42] gfx::GetFontRenderParams [0x02E97CED+344] gfx::GetFontRenderParams [0x02E97BF6+97] content::PpapiPluginMain [0x02304622+390] ... BUG=258201 NO_DEPENDENCY_CHECKS=true ==========
Sadly, I can't enable the LOG(FATAL) after all. Updated the CL description, and I'll tackle PPAPI browser_tests in a followup.
The CQ bit was checked by scottmg@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from esprehn@chromium.org, bsep@chromium.org, thakis@chromium.org, estade@chromium.org Link to the patchset: https://codereview.chromium.org/2290743002/#ps100001 (title: "no fatal yet :(")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
Description was changed from ========== Partial revert of https://codereview.chromium.org/1911973002/ This avoids calling NativeThemeWin methods in the renderer, which call user32, gdi32, and load uxtheme.dll, which we don't/can't do in the renderer. Also removes native_theme_win and native_theme_dark_win from child processes at the build file level. There's no way they could work in the renderer implemented as they are. NativeThemeAuraWin is removed as it was only used to special case scrollbars to NativeThemeWin, but that doesn't work. Attempted to readd a DLOG(FATAL) to SingletonHwnd(), but can't yet for a different reason, browser_tests: [3472:4712:0829/151623:FATAL:singleton_hwnd.cc(34)] Cannot create windows on non-UI thread! Backtrace: base::debug::StackTrace::StackTrace [0x023E3157+23] logging::LogMessage::~LogMessage [0x0239A681+49] gfx::SingletonHwnd::SingletonHwnd [0x02EA5A6E+111] base::Singleton<gfx::SingletonHwnd,base::DefaultSingletonTraits<gfx::SingletonHwnd>,gfx::SingletonHwnd>::get [0x02EA5BCB+42] gfx::GetFontRenderParams [0x02E97CED+344] gfx::GetFontRenderParams [0x02E97BF6+97] content::PpapiPluginMain [0x02304622+390] ... BUG=258201 NO_DEPENDENCY_CHECKS=true ========== to ========== Partial revert of https://codereview.chromium.org/1911973002/ This avoids calling NativeThemeWin methods in the renderer, which call user32, gdi32, and load uxtheme.dll, which we don't/can't do in the renderer. Also removes native_theme_win and native_theme_dark_win from child processes at the build file level. There's no way they could work in the renderer implemented as they are. NativeThemeAuraWin is removed as it was only used to special case scrollbars to NativeThemeWin, but that doesn't work. Attempted to readd a DLOG(FATAL) to SingletonHwnd(), but can't yet for a different reason, browser_tests: [3472:4712:0829/151623:FATAL:singleton_hwnd.cc(34)] Cannot create windows on non-UI thread! Backtrace: base::debug::StackTrace::StackTrace [0x023E3157+23] logging::LogMessage::~LogMessage [0x0239A681+49] gfx::SingletonHwnd::SingletonHwnd [0x02EA5A6E+111] base::Singleton<gfx::SingletonHwnd,base::DefaultSingletonTraits<gfx::SingletonHwnd>,gfx::SingletonHwnd>::get [0x02EA5BCB+42] gfx::GetFontRenderParams [0x02E97CED+344] gfx::GetFontRenderParams [0x02E97BF6+97] content::PpapiPluginMain [0x02304622+390] ... BUG=258201 ==========
The CQ bit was checked by scottmg@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from esprehn@chromium.org, bsep@chromium.org, thakis@chromium.org, estade@chromium.org Link to the patchset: https://codereview.chromium.org/2290743002/#ps110001 (title: "mac libtool")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Partial revert of https://codereview.chromium.org/1911973002/ This avoids calling NativeThemeWin methods in the renderer, which call user32, gdi32, and load uxtheme.dll, which we don't/can't do in the renderer. Also removes native_theme_win and native_theme_dark_win from child processes at the build file level. There's no way they could work in the renderer implemented as they are. NativeThemeAuraWin is removed as it was only used to special case scrollbars to NativeThemeWin, but that doesn't work. Attempted to readd a DLOG(FATAL) to SingletonHwnd(), but can't yet for a different reason, browser_tests: [3472:4712:0829/151623:FATAL:singleton_hwnd.cc(34)] Cannot create windows on non-UI thread! Backtrace: base::debug::StackTrace::StackTrace [0x023E3157+23] logging::LogMessage::~LogMessage [0x0239A681+49] gfx::SingletonHwnd::SingletonHwnd [0x02EA5A6E+111] base::Singleton<gfx::SingletonHwnd,base::DefaultSingletonTraits<gfx::SingletonHwnd>,gfx::SingletonHwnd>::get [0x02EA5BCB+42] gfx::GetFontRenderParams [0x02E97CED+344] gfx::GetFontRenderParams [0x02E97BF6+97] content::PpapiPluginMain [0x02304622+390] ... BUG=258201 ========== to ========== Partial revert of https://codereview.chromium.org/1911973002/ This avoids calling NativeThemeWin methods in the renderer, which call user32, gdi32, and load uxtheme.dll, which we don't/can't do in the renderer. Also removes native_theme_win and native_theme_dark_win from child processes at the build file level. There's no way they could work in the renderer implemented as they are. NativeThemeAuraWin is removed as it was only used to special case scrollbars to NativeThemeWin, but that doesn't work. Attempted to readd a DLOG(FATAL) to SingletonHwnd(), but can't yet for a different reason, browser_tests: [3472:4712:0829/151623:FATAL:singleton_hwnd.cc(34)] Cannot create windows on non-UI thread! Backtrace: base::debug::StackTrace::StackTrace [0x023E3157+23] logging::LogMessage::~LogMessage [0x0239A681+49] gfx::SingletonHwnd::SingletonHwnd [0x02EA5A6E+111] base::Singleton<gfx::SingletonHwnd,base::DefaultSingletonTraits<gfx::SingletonHwnd>,gfx::SingletonHwnd>::get [0x02EA5BCB+42] gfx::GetFontRenderParams [0x02E97CED+344] gfx::GetFontRenderParams [0x02E97BF6+97] content::PpapiPluginMain [0x02304622+390] ... BUG=258201 ==========
Message was sent while issue was closed.
Committed patchset #5 (id:110001)
Message was sent while issue was closed.
Description was changed from ========== Partial revert of https://codereview.chromium.org/1911973002/ This avoids calling NativeThemeWin methods in the renderer, which call user32, gdi32, and load uxtheme.dll, which we don't/can't do in the renderer. Also removes native_theme_win and native_theme_dark_win from child processes at the build file level. There's no way they could work in the renderer implemented as they are. NativeThemeAuraWin is removed as it was only used to special case scrollbars to NativeThemeWin, but that doesn't work. Attempted to readd a DLOG(FATAL) to SingletonHwnd(), but can't yet for a different reason, browser_tests: [3472:4712:0829/151623:FATAL:singleton_hwnd.cc(34)] Cannot create windows on non-UI thread! Backtrace: base::debug::StackTrace::StackTrace [0x023E3157+23] logging::LogMessage::~LogMessage [0x0239A681+49] gfx::SingletonHwnd::SingletonHwnd [0x02EA5A6E+111] base::Singleton<gfx::SingletonHwnd,base::DefaultSingletonTraits<gfx::SingletonHwnd>,gfx::SingletonHwnd>::get [0x02EA5BCB+42] gfx::GetFontRenderParams [0x02E97CED+344] gfx::GetFontRenderParams [0x02E97BF6+97] content::PpapiPluginMain [0x02304622+390] ... BUG=258201 ========== to ========== Partial revert of https://codereview.chromium.org/1911973002/ This avoids calling NativeThemeWin methods in the renderer, which call user32, gdi32, and load uxtheme.dll, which we don't/can't do in the renderer. Also removes native_theme_win and native_theme_dark_win from child processes at the build file level. There's no way they could work in the renderer implemented as they are. NativeThemeAuraWin is removed as it was only used to special case scrollbars to NativeThemeWin, but that doesn't work. Attempted to readd a DLOG(FATAL) to SingletonHwnd(), but can't yet for a different reason, browser_tests: [3472:4712:0829/151623:FATAL:singleton_hwnd.cc(34)] Cannot create windows on non-UI thread! Backtrace: base::debug::StackTrace::StackTrace [0x023E3157+23] logging::LogMessage::~LogMessage [0x0239A681+49] gfx::SingletonHwnd::SingletonHwnd [0x02EA5A6E+111] base::Singleton<gfx::SingletonHwnd,base::DefaultSingletonTraits<gfx::SingletonHwnd>,gfx::SingletonHwnd>::get [0x02EA5BCB+42] gfx::GetFontRenderParams [0x02E97CED+344] gfx::GetFontRenderParams [0x02E97BF6+97] content::PpapiPluginMain [0x02304622+390] ... BUG=258201 Committed: https://crrev.com/b92365ec08b7d2e96974df794dfb7a7f1ac347c8 Cr-Commit-Position: refs/heads/master@{#415420} ==========
Message was sent while issue was closed.
Patchset 5 (id:??) landed as https://crrev.com/b92365ec08b7d2e96974df794dfb7a7f1ac347c8 Cr-Commit-Position: refs/heads/master@{#415420} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
