Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 2287753002: Fix background of overflow shelf icon (Closed)

Created:
4 years, 3 months ago by Greg Levin
Modified:
4 years, 3 months ago
Reviewers:
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/pending/branch-heads/2785
Project:
chromium
Visibility:
Public.

Description

Fix background of overflow shelf icon BUG=640642 TEST=Add shelf icons and/or increase zoom until shelf overflows. Observe that background of overflow button is square, not round. Review-Url: https://codereview.chromium.org/2277523004 Cr-Commit-Position: refs/heads/master@{#414501} (cherry picked from commit cc77d07303f42212610e01d7fac2e8e4dd01647a) Committed: https://chromium.googlesource.com/chromium/src/+/805f2f810a2ab4bf8380b61571d79c7788c5044c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M ash/resources/ash_resources.grd View 1 chunk +3 lines, -0 lines 0 comments Download
M ash/resources/default_100_percent/common/shelf/status_icon_background_normal.png View Binary file 0 comments Download
M ash/resources/default_100_percent/common/shelf/status_icon_background_onblack_normal.png View Binary file 0 comments Download
M ash/resources/default_100_percent/common/shelf/status_icon_background_pressed.png View Binary file 0 comments Download
A + ash/resources/default_100_percent/common/shelf/status_launcher_icon_background_normal.png View Binary file 0 comments Download
A + ash/resources/default_100_percent/common/shelf/status_launcher_icon_background_onblack_normal.png View Binary file 0 comments Download
A + ash/resources/default_100_percent/common/shelf/status_launcher_icon_background_pressed.png View Binary file 0 comments Download
M ash/resources/default_200_percent/common/shelf/status_icon_background_normal.png View Binary file 0 comments Download
M ash/resources/default_200_percent/common/shelf/status_icon_background_onblack_normal.png View Binary file 0 comments Download
M ash/resources/default_200_percent/common/shelf/status_icon_background_pressed.png View Binary file 0 comments Download
A + ash/resources/default_200_percent/common/shelf/status_launcher_icon_background_normal.png View Binary file 0 comments Download
A + ash/resources/default_200_percent/common/shelf/status_launcher_icon_background_onblack_normal.png View Binary file 0 comments Download
A + ash/resources/default_200_percent/common/shelf/status_launcher_icon_background_pressed.png View Binary file 0 comments Download
M ash/shelf/app_list_button.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Greg Levin
4 years, 3 months ago (2016-08-26 22:05:59 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
805f2f810a2ab4bf8380b61571d79c7788c5044c.

Powered by Google App Engine
This is Rietveld 408576698