Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Issue 2277523004: Fix background of overflow shelf icon (Closed)

Created:
4 years, 4 months ago by Greg Levin
Modified:
4 years, 3 months ago
Reviewers:
oshima
CC:
chromium-reviews, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix background of overflow shelf icon BUG=640642 TEST=Add shelf icons and/or increase zoom until shelf overflows. Observe that background of overflow button is square, not round. Committed: https://crrev.com/cc77d07303f42212610e01d7fac2e8e4dd01647a Cr-Commit-Position: refs/heads/master@{#414501}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -6 lines) Patch
M ash/common/shelf/app_list_button.cc View 1 chunk +4 lines, -6 lines 0 comments Download
M ash/resources/ash_resources.grd View 1 chunk +3 lines, -0 lines 0 comments Download
M ash/resources/default_100_percent/common/shelf/status_icon_background_normal.png View Binary file 0 comments Download
M ash/resources/default_100_percent/common/shelf/status_icon_background_onblack_normal.png View Binary file 0 comments Download
M ash/resources/default_100_percent/common/shelf/status_icon_background_pressed.png View Binary file 0 comments Download
A + ash/resources/default_100_percent/common/shelf/status_launcher_icon_background_normal.png View Binary file 0 comments Download
A + ash/resources/default_100_percent/common/shelf/status_launcher_icon_background_onblack_normal.png View Binary file 0 comments Download
A + ash/resources/default_100_percent/common/shelf/status_launcher_icon_background_pressed.png View Binary file 0 comments Download
M ash/resources/default_200_percent/common/shelf/status_icon_background_normal.png View Binary file 0 comments Download
M ash/resources/default_200_percent/common/shelf/status_icon_background_onblack_normal.png View Binary file 0 comments Download
M ash/resources/default_200_percent/common/shelf/status_icon_background_pressed.png View Binary file 0 comments Download
A + ash/resources/default_200_percent/common/shelf/status_launcher_icon_background_normal.png View Binary file 0 comments Download
A + ash/resources/default_200_percent/common/shelf/status_launcher_icon_background_onblack_normal.png View Binary file 0 comments Download
A + ash/resources/default_200_percent/common/shelf/status_launcher_icon_background_pressed.png View Binary file 0 comments Download

Messages

Total messages: 13 (5 generated)
Greg Levin
Fixing what I broke in https://codereview.chromium.org/2234103002, didn't notice that background icons were used in two ...
4 years, 4 months ago (2016-08-24 20:13:24 UTC) #2
oshima
lgtm These icons looks like a easy target to convert to vector graphics? (I'm not ...
4 years, 4 months ago (2016-08-24 23:32:15 UTC) #3
Greg Levin
On 2016/08/24 23:32:15, oshima wrote: > lgtm > > These icons looks like a easy ...
4 years, 3 months ago (2016-08-25 15:21:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2277523004/1
4 years, 3 months ago (2016-08-25 15:22:27 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/268769)
4 years, 3 months ago (2016-08-25 17:35:16 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2277523004/1
4 years, 3 months ago (2016-08-25 18:17:07 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-25 19:10:08 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-08-25 19:12:40 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cc77d07303f42212610e01d7fac2e8e4dd01647a
Cr-Commit-Position: refs/heads/master@{#414501}

Powered by Google App Engine
This is Rietveld 408576698