Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Unified Diff: components/error_page/renderer/net_error_helper_core_unittest.cc

Issue 2287733002: Switch //components away from base::ListValue::Append(Value*) overload. (Closed)
Patch Set: Test fix Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/error_page/renderer/net_error_helper_core_unittest.cc
diff --git a/components/error_page/renderer/net_error_helper_core_unittest.cc b/components/error_page/renderer/net_error_helper_core_unittest.cc
index d73ea287ffa02fa67d7d6c3e18372c0033ba4a90..666d02d993409d3b4d4f843ceaef80e3574b425b 100644
--- a/components/error_page/renderer/net_error_helper_core_unittest.cc
+++ b/components/error_page/renderer/net_error_helper_core_unittest.cc
@@ -56,8 +56,8 @@ struct NavigationCorrection {
bool is_porn;
bool is_soft_porn;
- base::Value* ToValue() const {
- base::DictionaryValue* dict = new base::DictionaryValue();
+ std::unique_ptr<base::DictionaryValue> ToValue() const {
+ std::unique_ptr<base::DictionaryValue> dict(new base::DictionaryValue());
dict->SetString("correctionType", correction_type);
dict->SetString("urlCorrection", url_correction);
dict->SetString("clickType", click_type);

Powered by Google App Engine
This is Rietveld 408576698