Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(385)

Unified Diff: components/flags_ui/flags_state.cc

Issue 2287733002: Switch //components away from base::ListValue::Append(Value*) overload. (Closed)
Patch Set: Test fix Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/flags_ui/flags_state.cc
diff --git a/components/flags_ui/flags_state.cc b/components/flags_ui/flags_state.cc
index e0f1593b4543b1f5a1c81272113cce4bb7aeacc6..00c0c2a258483c851e30c0989758d1d9b0b13517 100644
--- a/components/flags_ui/flags_state.cc
+++ b/components/flags_ui/flags_state.cc
@@ -487,7 +487,7 @@ void FlagsState::GetFlagFeatureEntries(
if (skip_feature_entry.Run(entry))
continue;
- base::DictionaryValue* data = new base::DictionaryValue();
+ std::unique_ptr<base::DictionaryValue> data(new base::DictionaryValue());
data->SetString("internal_name", entry.internal_name);
data->SetString("name", l10n_util::GetStringUTF16(entry.visible_name_id));
data->SetString("description",
@@ -529,9 +529,9 @@ void FlagsState::GetFlagFeatureEntries(
supported = ((entry.supported_platforms & kOsIosAppleReview) != 0);
#endif
if (supported)
- supported_entries->Append(data);
+ supported_entries->Append(std::move(data));
else
- unsupported_entries->Append(data);
+ unsupported_entries->Append(std::move(data));
}
}

Powered by Google App Engine
This is Rietveld 408576698