Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Unified Diff: components/sync/syncable/write_transaction_info.cc

Issue 2287733002: Switch //components away from base::ListValue::Append(Value*) overload. (Closed)
Patch Set: rebase Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/sync/syncable/write_transaction_info.cc
diff --git a/components/sync/syncable/write_transaction_info.cc b/components/sync/syncable/write_transaction_info.cc
index 2dd1195d4188032cb75625e51ddd603f1582e0dc..d47b611aa8955f3e21f89fad9b3d08b0c1ac3f85 100644
--- a/components/sync/syncable/write_transaction_info.cc
+++ b/components/sync/syncable/write_transaction_info.cc
@@ -7,6 +7,7 @@
#include <stddef.h>
#include <stdint.h>
+#include "base/memory/ptr_util.h"
#include "base/strings/string_number_conversions.h"
namespace syncer {
@@ -35,15 +36,15 @@ base::DictionaryValue* WriteTransactionInfo::ToValue(
dict->SetString("id", base::Int64ToString(id));
dict->SetString("location", location_string);
dict->SetString("writer", WriterTagToString(writer));
- base::Value* mutations_value = NULL;
+ std::unique_ptr<base::Value> mutations_value;
const size_t mutations_size = mutations.Get().size();
if (mutations_size <= max_mutations_size) {
mutations_value = EntryKernelMutationMapToValue(mutations.Get());
} else {
- mutations_value = new base::StringValue(
+ mutations_value = base::MakeUnique<base::StringValue>(
base::SizeTToString(mutations_size) + " mutations");
}
- dict->Set("mutations", mutations_value);
+ dict->Set("mutations", std::move(mutations_value));
return dict;
}

Powered by Google App Engine
This is Rietveld 408576698