Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(620)

Unified Diff: components/user_prefs/tracked/pref_hash_calculator_unittest.cc

Issue 2287733002: Switch //components away from base::ListValue::Append(Value*) overload. (Closed)
Patch Set: rebase Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/user_prefs/tracked/pref_hash_calculator_unittest.cc
diff --git a/components/user_prefs/tracked/pref_hash_calculator_unittest.cc b/components/user_prefs/tracked/pref_hash_calculator_unittest.cc
index a2de0466ef20d93a44c8e524c3a871b651accd75..1b3ecd793f5f9a453fcc0228773af0f225584fd2 100644
--- a/components/user_prefs/tracked/pref_hash_calculator_unittest.cc
+++ b/components/user_prefs/tracked/pref_hash_calculator_unittest.cc
@@ -8,6 +8,7 @@
#include <string>
#include "base/macros.h"
+#include "base/memory/ptr_util.h"
#include "base/strings/string_util.h"
#include "base/values.h"
#include "testing/gtest/include/gtest/gtest.h"
@@ -91,9 +92,9 @@ TEST(PrefHashCalculatorTest, CatchHashChanges) {
nested_empty_dict->Set("a", new base::DictionaryValue);
nested_empty_dict->Set("b", new base::ListValue);
std::unique_ptr<base::ListValue> nested_empty_list(new base::ListValue);
- nested_empty_list->Append(new base::DictionaryValue);
- nested_empty_list->Append(new base::ListValue);
- nested_empty_list->Append(nested_empty_dict->DeepCopy());
+ nested_empty_list->Append(base::MakeUnique<base::DictionaryValue>());
+ nested_empty_list->Append(base::MakeUnique<base::ListValue>());
+ nested_empty_list->Append(nested_empty_dict->CreateDeepCopy());
// A dictionary with an empty dictionary, an empty list, and nested empty
// dictionaries/lists in it.

Powered by Google App Engine
This is Rietveld 408576698