Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 228763004: Revert 262487 "Add net/base/filename_util.h." (Closed)

Created:
6 years, 8 months ago by Sergey Ulanov
Modified:
6 years, 8 months ago
Reviewers:
Sergey Ulanov
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 262487 "Add net/base/filename_util.h." > Add net/base/filename_util.h. > > Moved some filename-related functions from net_util.h to the new > filename_util.h . > > BUG=276739 > R=piman@chromium.org, rsleevi@chromium.org > TBR=kalman@chromium.org, piman@chromium.org, sky@chromium.org > > Review URL: https://codereview.chromium.org/220253002 TBR=sergeyu@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262498

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2294 lines, -2354 lines) Patch
M trunk/src/chrome/browser/app_controller_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/chrome/browser/chrome_main_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/chrome/browser/chrome_plugin_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/chrome/browser/chromeos/drive/file_cache.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/chrome/browser/chromeos/file_manager/open_with_browser.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/chrome/browser/download/chrome_download_manager_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/chrome/browser/download/download_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/chrome/browser/download/download_target_determiner.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/chrome/browser/extensions/api/downloads/downloads_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/chrome/browser/extensions/api/execute_code_function.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/chrome/browser/extensions/api/push_messaging/sync_setup_helper.h View 1 chunk +0 lines, -4 lines 0 comments Download
M trunk/src/chrome/browser/extensions/docs/examples/apps/calculator_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/chrome/browser/extensions/extension_apitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/chrome/browser/extensions/extension_startup_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/chrome/browser/extensions/plugin_apitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/chrome/browser/history/redirect_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/chrome/browser/metrics/metrics_service_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/chrome/browser/ui/browser.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/chrome/browser/ui/cocoa/drag_util.mm View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/chrome/browser/ui/find_bar/find_bar_host_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/chrome/browser/ui/webui/about_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/chrome/browser/ui/webui/downloads_dom_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/chrome/browser/ui/webui/extensions/install_extension_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/chrome/common/net/url_fixer_upper.cc View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/chrome/common/net/url_fixer_upper_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/chrome/test/base/ui_test_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/chrome/test/base/web_ui_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/chrome/test/gpu/gpu_feature_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/chrome/test/ppapi/ppapi_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/components/policy/core/browser/url_blacklist_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/content/browser/child_process_security_policy_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/content/browser/download/save_file_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/content/browser/download/save_package.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/content/browser/renderer_host/render_view_host_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/content/browser/renderer_host/render_view_host_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/content/browser/renderer_host/render_view_host_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/content/browser/renderer_host/render_widget_host_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/content/browser/renderer_host/render_widget_host_view_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/content/browser/web_contents/web_contents_view_aura.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/content/browser/web_contents/web_drag_source_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/content/child/npapi/plugin_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/content/child/web_url_loader_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/content/child/webfileutilities_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/content/public/test/browser_test_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/content/public/test/content_browser_test_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/content/renderer/dom_serializer_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/content/renderer/savable_resources_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/content/shell/browser/shell_browser_main.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/content/shell/browser/shell_browser_main_parts.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/content/shell/browser/shell_devtools_frontend.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/content/shell/browser/shell_download_manager_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/content/shell/renderer/webkit_test_runner.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/content/test/net/url_request_mock_http_job.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/content/test/webui_resource_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/extensions/common/extension.cc View 1 chunk +1 line, -1 line 0 comments Download
D trunk/src/net/base/filename_util.h View 1 chunk +0 lines, -116 lines 0 comments Download
D trunk/src/net/base/filename_util.cc View 1 chunk +0 lines, -506 lines 0 comments Download
D trunk/src/net/base/filename_util_unittest.cc View 1 chunk +0 lines, -1652 lines 0 comments Download
M trunk/src/net/base/net_util.h View 3 chunks +94 lines, -0 lines 0 comments Download
M trunk/src/net/base/net_util.cc View 8 chunks +409 lines, -3 lines 0 comments Download
M trunk/src/net/base/net_util_posix.cc View 1 chunk +34 lines, -0 lines 0 comments Download
M trunk/src/net/base/net_util_unittest.cc View 7 chunks +1638 lines, -0 lines 0 comments Download
M trunk/src/net/base/net_util_win.cc View 1 chunk +53 lines, -0 lines 0 comments Download
M trunk/src/net/filter/filter.cc View 1 chunk +1 line, -2 lines 0 comments Download
M trunk/src/net/net.gyp View 4 chunks +7 lines, -10 lines 0 comments Download
M trunk/src/net/proxy/proxy_script_fetcher_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/net/url_request/file_protocol_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/net/url_request/url_request_file_job.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/net/url_request/url_request_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/ui/base/dragdrop/os_exchange_data_provider_aurax11.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/ui/base/dragdrop/os_exchange_data_provider_win.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Sergey Ulanov
6 years, 8 months ago (2014-04-08 20:33:26 UTC) #1
Sergey Ulanov
6 years, 8 months ago (2014-04-08 20:35:29 UTC) #2
Message was sent while issue was closed. 
Committed patchset #1 manually as r262498 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698