Add net/base/filename_util.h.

Add net/base/filename_util.h.

Moved some filename-related functions from net_util.h to the new
filename_util.h .

BUG=276739
R=piman@chromium.org, rsleevi@chromium.org
TBR=kalman@chromium.org, piman@chromium.org, sky@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262487

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262609

[Sergey Ulanov, 2014-03-31 23:58:53]

This makes the net_nacl CL smaller ( https://codereview.chromium.org/188873004/
).

[Ryan Sleevi, 2014-04-01 00:27:50]

On 2014/03/31 23:58:53, Sergey Ulanov wrote:
> This makes the net_nacl CL smaller (
https://codereview.chromium.org/188873004/
> ).

Are you not doing dead code elimination / unused function/section elimination?

Is it not able to eliminate this dead code?

[Sergey Ulanov, 2014-04-01 00:56:29]

On 2014/04/01 00:27:50, Ryan Sleevi wrote:
> On 2014/03/31 23:58:53, Sergey Ulanov wrote:
> > This makes the net_nacl CL smaller (
> https://codereview.chromium.org/188873004/
> > ).
> 
> Are you not doing dead code elimination / unused function/section elimination?
> 
> Is it not able to eliminate this dead code?

It's not about dead code elimination. Remoting code depends on some functions in
net_util.h/cc. But in net_nacl.cc there is also a lot of unrelated stuff which
doesn't compile for NaCl, e.g. FilePathToFileURL(). Moving this code to a
separate file allows to avoid these ifdefs (as in
https://codereview.chromium.org/188873004/diff/40001/net/base/net_util.cc ).

But even apart from the NaCl changes I think it's good idea to split net_util
into multiple parts. Currently it's a huge bag of unrelated nuts an bolts that's
hard to work with.

[Ryan Sleevi, 2014-04-01 01:07:32]

On 2014/04/01 00:56:29, Sergey Ulanov wrote:
> On 2014/04/01 00:27:50, Ryan Sleevi wrote:
> > On 2014/03/31 23:58:53, Sergey Ulanov wrote:
> > > This makes the net_nacl CL smaller (
> > https://codereview.chromium.org/188873004/
> > > ).
> > 
> > Are you not doing dead code elimination / unused function/section
elimination?
> > 
> > Is it not able to eliminate this dead code?
> 
> It's not about dead code elimination. Remoting code depends on some functions
in
> net_util.h/cc. But in net_nacl.cc there is also a lot of unrelated stuff which
> doesn't compile for NaCl, e.g. FilePathToFileURL(). Moving this code to a
> separate file allows to avoid these ifdefs (as in
> https://codereview.chromium.org/188873004/diff/40001/net/base/net_util.cc ).
> 
> But even apart from the NaCl changes I think it's good idea to split net_util
> into multiple parts. Currently it's a huge bag of unrelated nuts an bolts
that's
> hard to work with.

D'oh! I misread this as "makes net_nacl smaller" - as in binary code-size.

I now see, after reading your reply, you said "the net_nacl CL", which makes
perfect sense :)

[Sergey Ulanov, 2014-04-04 19:28:16]

rsleevi: ping

[Ryan Sleevi, 2014-04-07 16:38:38]

Sorry for the delay, was out sick.

LGTM.

https://codereview.chromium.org/220253002/diff/210001/net/base/net_util.cc
File net/base/net_util.cc (right):

https://codereview.chromium.org/220253002/diff/210001/net/base/net_util.cc#ne...
net/base/net_util.cc:12: #include <set>
What prompted these additions? Linter? I agree they're correct, just curious how
you caught them.

[Sergey Ulanov, 2014-04-07 19:44:35]

https://codereview.chromium.org/220253002/diff/210001/net/base/net_util.cc
File net/base/net_util.cc (right):

https://codereview.chromium.org/220253002/diff/210001/net/base/net_util.cc#ne...
net/base/net_util.cc:12: #include <set>
On 2014/04/07 16:38:39, Ryan Sleevi wrote:
> What prompted these additions? Linter? I agree they're correct, just curious
how
> you caught them.

It wasn't compiling without these - they were somehow included by the other
included headers I removed below.

[Sergey Ulanov, 2014-04-07 19:47:19]

+kalman (extensions), sky (ui, chrome), piman (content) in TBR for trivial
changes.

[Sergey Ulanov, 2014-04-07 19:48:08]

The CQ bit was checked by sergeyu@chromium.org

[commit-bot: I haz the power, 2014-04-07 19:48:21]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sergeyu@chromium.org/220253002/230001

[commit-bot: I haz the power, 2014-04-07 19:53:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-07 19:53:33]

Try jobs failed on following builders:
  tryserver.chromium on win_chromium_compile_dbg

[piman, 2014-04-07 21:03:20]

lgtm

[Sergey Ulanov, 2014-04-08 19:55:14]

Committed patchset #15 manually as r262487.

[Sergey Ulanov, 2014-04-09 04:05:35]

Committed patchset #16 manually as r262609.