Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2837)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: build/toolchain/win/midl.gni

Issue 2287603003: Move gyp-win-tool to the GN Windows toolchain. (Closed)
Patch Set: fix Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« build/toolchain/win/BUILD.gn ('K') | « build/toolchain/win/BUILD.gn ('k') | build/toolchain/win/setup_toolchain.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/toolchain/win/midl.gni
diff --git a/build/toolchain/win/midl.gni b/build/toolchain/win/midl.gni
index ff5899c8c7840cc57d6a0434454e1317d23c5b32..08b558678a1957bb80d5583885ad3346e5663cf7 100644
--- a/build/toolchain/win/midl.gni
+++ b/build/toolchain/win/midl.gni
@@ -44,8 +44,8 @@ template("midl") {
# This functionality is handled by the win-tool because the GYP build has
# MIDL support built-in.
# TODO(brettw) move this to a separate MIDL wrapper script for better
- # clarity once GYP support is not needed.
- script = "$root_build_dir/gyp-win-tool"
+ # clarity.
+ script = "//build/toolchain/win/tool_wrapper.py"
sources = invoker.sources
« build/toolchain/win/BUILD.gn ('K') | « build/toolchain/win/BUILD.gn ('k') | build/toolchain/win/setup_toolchain.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698