Chromium Code Reviews| Index: build/toolchain/win/BUILD.gn |
| diff --git a/build/toolchain/win/BUILD.gn b/build/toolchain/win/BUILD.gn |
| index 0549a6b698dc86a1a061076dc70158a8b4c4844d..45d062bea39ada2cee0e5ab234239ae3b397eac1 100644 |
| --- a/build/toolchain/win/BUILD.gn |
| +++ b/build/toolchain/win/BUILD.gn |
| @@ -17,8 +17,10 @@ assert(is_win) |
| # Its arguments are the VS path and the compiler wrapper tool. It will write |
| # "environment.x86" and "environment.x64" to the build directory and return a |
| # list to us. |
| -gyp_win_tool_path = |
| - rebase_path("//tools/gyp/pylib/gyp/win_tool.py", root_build_dir) |
| + |
| +# This tool will get copied to the build directory and wraps some common |
| +# commands. |
| +tool_wrapper_path = rebase_path("tool_wrapper.py", root_build_dir) |
|
scottmg
2016/08/26 20:54:36
We are going to still copy it? So now using it fro
brettw
2016/08/26 20:57:07
It's not copied. This is rebasing the path "tool_w
scottmg
2016/08/26 20:59:04
OK, I was misled by the prominent comment directly
brettw
2016/08/26 21:00:27
Whoops, fixed!
|
| if (use_goma) { |
| goma_prefix = "$goma_dir/gomacc.exe " |
| @@ -160,7 +162,7 @@ template("msvc_toolchain") { |
| } |
| tool("rc") { |
| - command = "$python_path gyp-win-tool rc-wrapper $env rc.exe {{defines}} {{include_dirs}} /fo{{output}} {{source}}" |
| + command = "$python_path $tool_wrapper_path rc-wrapper $env rc.exe {{defines}} {{include_dirs}} /fo{{output}} {{source}}" |
| outputs = [ |
| "$object_subdir/{{source_name_part}}.res", |
| ] |
| @@ -173,7 +175,7 @@ template("msvc_toolchain") { |
| } else { |
| ml = "ml.exe" |
| } |
| - command = "$python_path gyp-win-tool asm-wrapper $env $ml {{defines}} {{include_dirs}} {{asmflags}} /c /Fo{{output}} {{source}}" |
| + command = "$python_path $tool_wrapper_path asm-wrapper $env $ml {{defines}} {{include_dirs}} {{asmflags}} /c /Fo{{output}} {{source}}" |
| description = "ASM {{output}}" |
| outputs = [ |
| "$object_subdir/{{source_name_part}}.obj", |
| @@ -182,7 +184,7 @@ template("msvc_toolchain") { |
| tool("alink") { |
| rspfile = "{{output}}.rsp" |
| - command = "$python_path gyp-win-tool link-wrapper $env False $lib /nologo {{arflags}} /OUT:{{output}} @$rspfile" |
| + command = "$python_path $tool_wrapper_path link-wrapper $env False $lib /nologo {{arflags}} /OUT:{{output}} @$rspfile" |
| description = "LIB {{output}}" |
| outputs = [ |
| # Ignore {{output_extension}} and always use .lib, there's no reason to |
| @@ -204,7 +206,7 @@ template("msvc_toolchain") { |
| rspfile = "${dllname}.rsp" |
| pool = "//build/toolchain:link_pool($default_toolchain)" |
| - command = "$python_path gyp-win-tool link-wrapper $env False $link /nologo /IMPLIB:$libname /DLL /OUT:$dllname /PDB:$pdbname @$rspfile" |
| + command = "$python_path $tool_wrapper_path link-wrapper $env False $link /nologo /IMPLIB:$libname /DLL /OUT:$dllname /PDB:$pdbname @$rspfile" |
| default_output_extension = ".dll" |
| default_output_dir = "{{root_out_dir}}" |
| @@ -237,7 +239,7 @@ template("msvc_toolchain") { |
| rspfile = "${dllname}.rsp" |
| pool = "//build/toolchain:link_pool($default_toolchain)" |
| - command = "$python_path gyp-win-tool link-wrapper $env False $link /nologo /DLL /OUT:$dllname /PDB:$pdbname @$rspfile" |
| + command = "$python_path $tool_wrapper_path link-wrapper $env False $link /nologo /DLL /OUT:$dllname /PDB:$pdbname @$rspfile" |
| default_output_extension = ".dll" |
| default_output_dir = "{{root_out_dir}}" |
| @@ -261,7 +263,7 @@ template("msvc_toolchain") { |
| rspfile = "$exename.rsp" |
| pool = "//build/toolchain:link_pool($default_toolchain)" |
| - command = "$python_path gyp-win-tool link-wrapper $env False $link /nologo /OUT:$exename /PDB:$pdbname @$rspfile" |
| + command = "$python_path $tool_wrapper_path link-wrapper $env False $link /nologo /OUT:$exename /PDB:$pdbname @$rspfile" |
| default_output_extension = ".exe" |
| default_output_dir = "{{root_out_dir}}" |
| @@ -313,7 +315,6 @@ if (target_cpu == "x86") { |
| x86_toolchain_data = exec_script("setup_toolchain.py", |
| [ |
| visual_studio_path, |
| - gyp_win_tool_path, |
| windows_sdk_path, |
| visual_studio_runtime_dirs, |
| "x86", |
| @@ -347,7 +348,6 @@ if (target_cpu == "x86") { |
| x64_toolchain_data = exec_script("setup_toolchain.py", |
| [ |
| visual_studio_path, |
| - gyp_win_tool_path, |
| windows_sdk_path, |
| visual_studio_runtime_dirs, |
| "x64", |