Linux: Remove --wm-user-time-ms command line argument

Linux: Remove --wm-user-time-ms command line argument

CL ca3656d added the --wm-user-time-ms command line argument so that
window activation would be more reliable.  However, its implementation
was awkward and complex, and is no longer needed now that
X11EventSource::GetTimestamp() provides the correct functionality.

Explanation: X11EventSource::GetTimestamp() gives the timestamp of the
event currently being dispatched.  If there's no event being
dispatched, or the event does not have a timestamp, we fall back on
making a round trip.  Simply using last_seen_server_time like we did
with activation before ca3656d meant that the timestamp we used could
be out of date if we were activating in response to anything other
than a user input event.  This is what led to the --wm-user-time-ms
hack.

Committed: https://crrev.com/e529d3df7073d643f2176bbc4e6534f00d072209
Cr-Commit-Position: refs/heads/master@{#416411}

[Tom (Use chromium acct), 2016-08-27 00:02:58]

thomasanderson@google.com changed reviewers:
+ sky@chromium.org

[Daniel Erat, 2016-08-27 01:47:06]

derat@chromium.org changed reviewers:
+ derat@chromium.org

[Daniel Erat, 2016-08-27 01:47:07]

lgtm

https://codereview.chromium.org/2287583003/diff/1/ui/events/platform/x11/x11_...
File ui/events/platform/x11/x11_event_source.cc (right):

https://codereview.chromium.org/2287583003/diff/1/ui/events/platform/x11/x11_...
ui/events/platform/x11/x11_event_source.cc:179:
"Event.Latency.X11EventSource.UpdateServerTime",
nit: time to consider fixing this histogram name?

https://codereview.chromium.org/2287583003/diff/1/ui/events/platform/x11/x11_...
File ui/events/platform/x11/x11_event_source.h (right):

https://codereview.chromium.org/2287583003/diff/1/ui/events/platform/x11/x11_...
ui/events/platform/x11/x11_event_source.h:75: // on GetCurrentServertime() if
there's no event being dispatched, or if the
nit: s/time/Time/

[sky, 2016-08-29 15:59:55]

LGTM

[Tom (Use chromium acct), 2016-08-30 19:12:38]

The CQ bit was checked by thomasanderson@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-30 19:13:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Tom (Use chromium acct), 2016-08-30 19:14:57]

thomasanderson@google.com changed reviewers:
+ jwd@chromium.org

[Tom (Use chromium acct), 2016-08-30 19:14:58]

+jwd for histograms

https://codereview.chromium.org/2287583003/diff/1/ui/events/platform/x11/x11_...
File ui/events/platform/x11/x11_event_source.cc (right):

https://codereview.chromium.org/2287583003/diff/1/ui/events/platform/x11/x11_...
ui/events/platform/x11/x11_event_source.cc:179:
"Event.Latency.X11EventSource.UpdateServerTime",
On 2016/08/27 01:47:07, Daniel Erat wrote:
> nit: time to consider fixing this histogram name?

Done.

https://codereview.chromium.org/2287583003/diff/1/ui/events/platform/x11/x11_...
File ui/events/platform/x11/x11_event_source.h (right):

https://codereview.chromium.org/2287583003/diff/1/ui/events/platform/x11/x11_...
ui/events/platform/x11/x11_event_source.h:75: // on GetCurrentServertime() if
there's no event being dispatched, or if the
On 2016/08/27 01:47:07, Daniel Erat wrote:
> nit: s/time/Time/

Done.

[commit-bot: I haz the power, 2016-08-30 19:16:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-30 19:16:34]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Tom (Use chromium acct), 2016-08-30 19:19:37]

Patchset #2 (id:20001) has been deleted

[Tom (Use chromium acct), 2016-08-30 19:21:36]

Patchset #2 (id:40001) has been deleted

[Tom (Use chromium acct), 2016-08-30 19:21:41]

The CQ bit was checked by thomasanderson@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-30 19:22:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-30 21:03:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-30 21:03:20]

Dry run: This issue passed the CQ dry run.

[jwd, 2016-08-31 14:13:00]

https://codereview.chromium.org/2287583003/diff/60001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (left):

https://codereview.chromium.org/2287583003/diff/60001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:13485: -    units="microseconds">
Please mark this as obsolete with a mm/yyyy of when, instead of removing it.

[Tom (Use chromium acct), 2016-08-31 17:27:48]

https://codereview.chromium.org/2287583003/diff/60001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (left):

https://codereview.chromium.org/2287583003/diff/60001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:13485: -    units="microseconds">
On 2016/08/31 14:13:00, jwd wrote:
> Please mark this as obsolete with a mm/yyyy of when, instead of removing it.

Done.

[jwd, 2016-08-31 20:15:22]

lgtm

[Tom (Use chromium acct), 2016-08-31 20:24:47]

The CQ bit was checked by thomasanderson@google.com

[Tom (Use chromium acct), 2016-08-31 20:24:47]

The patchset sent to the CQ was uploaded after l-g-t-m from derat@chromium.org,
sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2287583003/#ps80001
(title: "Deprecate histogram")

[commit-bot: I haz the power, 2016-08-31 20:25:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-31 21:19:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-31 21:19:22]

Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Tom (Use chromium acct), 2016-08-31 21:27:31]

The CQ bit was checked by thomasanderson@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-31 21:28:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-31 22:12:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-31 22:12:27]

Dry run: This issue passed the CQ dry run.

[Tom (Use chromium acct), 2016-09-02 22:46:47]

The CQ bit was checked by thomasanderson@google.com

[commit-bot: I haz the power, 2016-09-02 22:47:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-03 00:33:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-03 00:33:22]

Failed to apply the patch.
On branch working_branch
Your branch is up-to-date with 'origin/refs/pending/heads/master'.
nothing to commit, working tree clean

[commit-bot: I haz the power, 2016-09-03 00:34:07]

Description was changed from

==========
Linux: Remove --wm-user-time-ms command line argument

CL ca3656d added the --wm-user-time-ms command line argument so that
window activation would be more reliable.  However, its implementation
was awkward and complex, and is no longer needed now that
X11EventSource::GetTimestamp() provides the correct functionality.

Explanation: X11EventSource::GetTimestamp() gives the timestamp of the
event currently being dispatched.  If there's no event being
dispatched, or the event does not have a timestamp, we fall back on
making a round trip.  Simply using last_seen_server_time like we did
with activation before ca3656d meant that the timestamp we used could
be out of date if we were activating in response to anything other
than a user input event.  This is what led to the --wm-user-time-ms
hack.
==========

to

==========
Linux: Remove --wm-user-time-ms command line argument

CL ca3656d added the --wm-user-time-ms command line argument so that
window activation would be more reliable.  However, its implementation
was awkward and complex, and is no longer needed now that
X11EventSource::GetTimestamp() provides the correct functionality.

Explanation: X11EventSource::GetTimestamp() gives the timestamp of the
event currently being dispatched.  If there's no event being
dispatched, or the event does not have a timestamp, we fall back on
making a round trip.  Simply using last_seen_server_time like we did
with activation before ca3656d meant that the timestamp we used could
be out of date if we were activating in response to anything other
than a user input event.  This is what led to the --wm-user-time-ms
hack.

Committed: https://crrev.com/e529d3df7073d643f2176bbc4e6534f00d072209
Cr-Commit-Position: refs/heads/master@{#416411}
==========

[commit-bot: I haz the power, 2016-09-03 00:34:09]

Patchset 3 (id:??) landed as
https://crrev.com/e529d3df7073d643f2176bbc4e6534f00d072209
Cr-Commit-Position: refs/heads/master@{#416411}