Index: chrome/android/java/res/layout/multiline_spinner_item.xml |
diff --git a/chrome/android/java/res/layout/infobar_control_spinner_drop_down.xml b/chrome/android/java/res/layout/multiline_spinner_item.xml |
similarity index 56% |
copy from chrome/android/java/res/layout/infobar_control_spinner_drop_down.xml |
copy to chrome/android/java/res/layout/multiline_spinner_item.xml |
index 1b5222c14b983af66a51a1e4b1d69c38940073cd..f6913f84b283a737e3054827906f6750d82d3271 100644 |
--- a/chrome/android/java/res/layout/infobar_control_spinner_drop_down.xml |
+++ b/chrome/android/java/res/layout/multiline_spinner_item.xml |
@@ -1,17 +1,15 @@ |
<?xml version="1.0" encoding="utf-8"?> |
please use gerrit instead
2016/08/26 16:46:15
Since you decided to go with ellipsis instead of m
sebsg
2016/08/26 19:36:45
That resource file is for the text value of the dr
|
- |
<!-- Copyright 2016 The Chromium Authors. All rights reserved. |
+ |
Use of this source code is governed by a BSD-style license that can be |
found in the LICENSE file. |
--> |
-<TextView xmlns:android="http://schemas.android.com/apk/res/android" |
- android:id="@+id/control_spinner_drop_down" |
+<TextView xmlns:android="http://schemas.android.com/apk/res/android" |
please use gerrit instead
2016/08/26 16:46:15
Is this a trailing whitespace? If so, remove it.
sebsg
2016/08/26 19:36:45
Done.
|
+ android:id="@android:id/text1" |
please use gerrit instead
2016/08/26 16:46:15
Remove the ID
sebsg
2016/08/26 19:36:45
Done.
|
+ style="?android:attr/spinnerItemStyle" |
+ android:singleLine="false" |
please use gerrit instead
2016/08/26 16:46:15
If you want a single-line with ellipsis, then you
sebsg
2016/08/26 19:36:45
This one actually does multiline :)
|
android:layout_width="match_parent" |
android:layout_height="wrap_content" |
- android:layout_marginTop="10dp" |
- android:layout_marginBottom="10dp" |
- android:background="?android:attr/selectableItemBackground" |
- android:ellipsize="end" |
- android:padding="10dp" |
- android:singleLine="true" /> |
+ android:ellipsize="marquee" |
+ android:textAlignment="inherit"/> |