chrome/android/java/res/layout/multiline_spinner_item.xml - Issue 2287513002: [Payments] Show name and address when selecting a CC billing address.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/android/java/res/layout/multiline_spinner_item.xml

Issue 2287513002: [Payments] Show name and address when selecting a CC billing address. (Closed)

Patch Set: Added the layout file Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/autofill/PersonalDataManager.java » ('j') | chrome/android/java/src/org/chromium/chrome/browser/autofill/PersonalDataManager.java » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <?xml version="1.0" encoding="utf-8"?>	1 <?xml version="1.0" encoding="utf-8"?>
	please use gerrit instead 2016/08/26 16:46:15 Since you decided to go with ellipsis instead of m Since you decided to go with ellipsis instead of multiline for spinner items, do we still need this file? If we need it, it should be called something like "ellipsis_spinner_item.xml" not "multiline_spinner_item.xml", right? :-) sebsg 2016/08/26 19:36:45 That resource file is for the text value of the dr Show quoted text On 2016/08/26 16:46:15, rouslan wrote: > Since you decided to go with ellipsis instead of multiline for spinner items, do > we still need this file? > > If we need it, it should be called something like "ellipsis_spinner_item.xml" > not "multiline_spinner_item.xml", right? :-) That resource file is for the text value of the drop down. The selections use ellipsis but once you selected it we can show multiline :)
	2 <!-- Copyright 2016 The Chromium Authors. All rights reserved.

2	3

3 <!-- Copyright 2016 The Chromium Authors. All rights reserved.

4 Use of this source code is governed by a BSD-style license that can be	4 Use of this source code is governed by a BSD-style license that can be

5 found in the LICENSE file.	5 found in the LICENSE file.

6 -->	6 -->

7	7

8 <TextView xmlns:android="http://schemas.android.com/apk/res/android"	8 <TextView xmlns:android="http://schemas.android.com/apk/res/android"
	please use gerrit instead 2016/08/26 16:46:15 Is this a trailing whitespace? If so, remove it. Is this a trailing whitespace? If so, remove it. sebsg 2016/08/26 19:36:45 Done. Show quoted text On 2016/08/26 16:46:15, rouslan wrote: > Is this a trailing whitespace? If so, remove it. Done.
9 android:id="@+id/control_spinner_drop_down"	9 android:id="@android:id/text1"
	please use gerrit instead 2016/08/26 16:46:15 Remove the ID Remove the ID sebsg 2016/08/26 19:36:45 Done. Show quoted text On 2016/08/26 16:46:15, rouslan wrote: > Remove the ID Done.
	10 style="?android:attr/spinnerItemStyle"

	11 android:singleLine="false"
	please use gerrit instead 2016/08/26 16:46:15 If you want a single-line with ellipsis, then you If you want a single-line with ellipsis, then you should set singleLine="true". sebsg 2016/08/26 19:36:45 This one actually does multiline :) Show quoted text On 2016/08/26 16:46:15, rouslan wrote: > If you want a single-line with ellipsis, then you should set singleLine="true". This one actually does multiline :)
10 android:layout_width="match_parent"	12 android:layout_width="match_parent"

11 android:layout_height="wrap_content"	13 android:layout_height="wrap_content"

12 android:layout_marginTop="10dp"	14 android:ellipsize="marquee"

13 android:layout_marginBottom="10dp"	15 android:textAlignment="inherit"/>

14 android:background="?android:attr/selectableItemBackground"

15 android:ellipsize="end"

16 android:padding="10dp"

17 android:singleLine="true" />

OLD	NEW