tools/flags/SkCommandLineFlags.cpp - Issue 22875037: My clang now doesn't complain about !"foo".

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/flags/SkCommandLineFlags.cpp

Issue 22875037: My clang now doesn't complain about !"foo". (Closed) Base URL: https://skia.googlecode.com/svn/trunk

Patch Set: Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/flags/SkCommandLineFlags.cpp

diff --git a/tools/flags/SkCommandLineFlags.cpp b/tools/flags/SkCommandLineFlags.cpp

index b088b4e4d38ec6675bd4c64c3b779b0cc5313975..084f48a8aab254f3a3e8cd496b547725bd7532a1 100644

--- a/tools/flags/SkCommandLineFlags.cpp

+++ b/tools/flags/SkCommandLineFlags.cpp

@@ -278,7 +278,7 @@ void SkCommandLineFlags::Parse(int argc, char** argv) {

flag->setDouble(atof(argv[i]));

break;

default:

- SkASSERT(!"Invalid flag type");

+ SkDEBUGFAIL("Invalid flag type");

}

break;

}

« no previous file with comments | « tools/flags/SkCommandLineFlags.h ('k') | no next file » | no next file with comments »