Source/core/dom/DOMImplementation.idl - Issue 22875013: Make several DOMImplementation API arguments mandatory

Unified Diff: Source/core/dom/DOMImplementation.idl

Issue 22875013: Make several DOMImplementation API arguments mandatory (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Keep hasFeature() as it was Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/dom/DOMImplementation.idl

diff --git a/Source/core/dom/DOMImplementation.idl b/Source/core/dom/DOMImplementation.idl

index 0d627f502f92107592dfa2d34ac0c0801e7d6ea0..c110cb4d32efde109df071a7b6fb12250cd08d32 100644

--- a/Source/core/dom/DOMImplementation.idl

+++ b/Source/core/dom/DOMImplementation.idl

@@ -29,12 +29,12 @@

// DOM Level 2

- [RaisesException] DocumentType createDocumentType([TreatNullAs=NullString, TreatUndefinedAs=NullString,Default=Undefined] optional DOMString qualifiedName,

- [TreatNullAs=NullString, TreatUndefinedAs=NullString,Default=Undefined] optional DOMString publicId,

- [TreatNullAs=NullString, TreatUndefinedAs=NullString,Default=Undefined] optional DOMString systemId);

- [RaisesException] Document createDocument([TreatNullAs=NullString,Default=Undefined] optional DOMString namespaceURI,

- [TreatNullAs=NullString,Default=Undefined] optional DOMString qualifiedName,

- [TreatNullAs=NullString,Default=Undefined] optional DocumentType doctype);

+ [RaisesException] DocumentType createDocumentType([TreatNullAs=NullString] DOMString qualifiedName,

+ [TreatNullAs=NullString] DOMString publicId,

+ [TreatNullAs=NullString] DOMString systemId);

+ [RaisesException] Document createDocument([TreatNullAs=NullString] DOMString namespaceURI,

+ [TreatNullAs=NullString] DOMString qualifiedName,

+ [Default=Undefined] optional DocumentType doctype);

arv (Not doing code reviews) 2013/08/16 13:33:27 Why is [Default=Undefined] needed?

do-not-use 2013/08/16 13:47:03 It did not compile otherwise because the implement

arv (Not doing code reviews) 2013/08/16 13:59:09 Why not [Default=Null]?

// DOMImplementationCSS interface from DOM Level 2 CSS

« LayoutTests/fast/dom/HTMLLinkElement/prefetch-detached.html ('K') | « LayoutTests/svg/animations/smil-element-target-crash-main.html ('k') | no next file » | no next file with comments »