 Chromium Code Reviews
 Chromium Code Reviews Issue 22875013:
  Make several DOMImplementation API arguments mandatory  (Closed) 
  Base URL: svn://svn.chromium.org/blink/trunk
    
  
    Issue 22875013:
  Make several DOMImplementation API arguments mandatory  (Closed) 
  Base URL: svn://svn.chromium.org/blink/trunk| OLD | NEW | 
|---|---|
| 1 /* | 1 /* | 
| 2 * Copyright (C) 2006, 2007 Apple Inc. All rights reserved. | 2 * Copyright (C) 2006, 2007 Apple Inc. All rights reserved. | 
| 3 * Copyright (C) 2006 Samuel Weinig <sam.weinig@gmail.com> | 3 * Copyright (C) 2006 Samuel Weinig <sam.weinig@gmail.com> | 
| 4 * | 4 * | 
| 5 * This library is free software; you can redistribute it and/or | 5 * This library is free software; you can redistribute it and/or | 
| 6 * modify it under the terms of the GNU Library General Public | 6 * modify it under the terms of the GNU Library General Public | 
| 7 * License as published by the Free Software Foundation; either | 7 * License as published by the Free Software Foundation; either | 
| 8 * version 2 of the License, or (at your option) any later version. | 8 * version 2 of the License, or (at your option) any later version. | 
| 9 * | 9 * | 
| 10 * This library is distributed in the hope that it will be useful, | 10 * This library is distributed in the hope that it will be useful, | 
| (...skipping 11 matching lines...) Expand all Loading... | |
| 22 GenerateIsReachable=document | 22 GenerateIsReachable=document | 
| 23 ] interface DOMImplementation { | 23 ] interface DOMImplementation { | 
| 24 | 24 | 
| 25 // DOM Level 1 | 25 // DOM Level 1 | 
| 26 | 26 | 
| 27 boolean hasFeature([Default=Undefined] optional DOMString feature, | 27 boolean hasFeature([Default=Undefined] optional DOMString feature, | 
| 28 [TreatNullAs=NullString,Default=Undefined] optional DOMString version); | 28 [TreatNullAs=NullString,Default=Undefined] optional DOMString version); | 
| 29 | 29 | 
| 30 // DOM Level 2 | 30 // DOM Level 2 | 
| 31 | 31 | 
| 32 [RaisesException] DocumentType createDocumentType([TreatNullAs=NullString, TreatUndefinedAs=NullString,Default=Undefined] optional DOMString qualifiedName, | 32 [RaisesException] DocumentType createDocumentType([TreatNullAs=NullString] DOMString qualifiedName, | 
| 33 [TreatNullAs=NullString, Trea tUndefinedAs=NullString,Default=Undefined] optional DOMString publicId, | 33 [TreatNullAs=NullString] DOMString publicId, | 
| 34 [TreatNullAs=NullString, Trea tUndefinedAs=NullString,Default=Undefined] optional DOMString systemId); | 34 [TreatNullAs=NullString] DOMString systemId); | 
| 35 [RaisesException] Document createDocument([TreatNullAs=NullString,Default=U ndefined] optional DOMString namespaceURI, | 35 [RaisesException] Document createDocument([TreatNullAs=NullString] DOMStrin g namespaceURI, | 
| 36 [TreatNullAs=NullString,Default=Undef ined] optional DOMString qualifiedName, | 36 [TreatNullAs=NullString] DOMStrin g qualifiedName, | 
| 37 [TreatNullAs=NullString,Default=Undef ined] optional DocumentType doctype); | 37 [Default=Undefined] optional Docu mentType doctype); | 
| 
arv (Not doing code reviews)
2013/08/16 13:33:27
Why is [Default=Undefined] needed?
 
do-not-use
2013/08/16 13:47:03
It did not compile otherwise because the implement
 
arv (Not doing code reviews)
2013/08/16 13:59:09
Why not [Default=Null]?
 | |
| 38 | 38 | 
| 39 // DOMImplementationCSS interface from DOM Level 2 CSS | 39 // DOMImplementationCSS interface from DOM Level 2 CSS | 
| 40 | 40 | 
| 41 CSSStyleSheet createCSSStyleSheet([Default=Undefined] optional DOMString ti tle, | 41 CSSStyleSheet createCSSStyleSheet([Default=Undefined] optional DOMString ti tle, | 
| 42 [Default=Undefined] optional DOMString me dia); | 42 [Default=Undefined] optional DOMString me dia); | 
| 43 | 43 | 
| 44 // HTMLDOMImplementation interface from DOM Level 2 HTML | 44 // HTMLDOMImplementation interface from DOM Level 2 HTML | 
| 45 | 45 | 
| 46 HTMLDocument createHTMLDocument([Default=NullString] optional DOMString titl e); | 46 HTMLDocument createHTMLDocument([Default=NullString] optional DOMString titl e); | 
| 47 }; | 47 }; | 
| 48 | 48 | 
| OLD | NEW |