Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(779)

Unified Diff: Source/core/dom/DOMImplementation.idl

Issue 22875013: Make several DOMImplementation API arguments mandatory (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/dom/DOMImplementation.idl
diff --git a/Source/core/dom/DOMImplementation.idl b/Source/core/dom/DOMImplementation.idl
index 0d627f502f92107592dfa2d34ac0c0801e7d6ea0..b45c529871fbe6baf284aad2ccd029f702ad787f 100644
--- a/Source/core/dom/DOMImplementation.idl
+++ b/Source/core/dom/DOMImplementation.idl
@@ -24,17 +24,16 @@
// DOM Level 1
- boolean hasFeature([Default=Undefined] optional DOMString feature,
- [TreatNullAs=NullString,Default=Undefined] optional DOMString version);
+ boolean hasFeature(DOMString feature, [TreatNullAs=NullString] DOMString version);
arv (Not doing code reviews) 2013/08/14 15:08:22 These changes make little sense. A nullable param
// DOM Level 2
- [RaisesException] DocumentType createDocumentType([TreatNullAs=NullString, TreatUndefinedAs=NullString,Default=Undefined] optional DOMString qualifiedName,
- [TreatNullAs=NullString, TreatUndefinedAs=NullString,Default=Undefined] optional DOMString publicId,
- [TreatNullAs=NullString, TreatUndefinedAs=NullString,Default=Undefined] optional DOMString systemId);
- [RaisesException] Document createDocument([TreatNullAs=NullString,Default=Undefined] optional DOMString namespaceURI,
- [TreatNullAs=NullString,Default=Undefined] optional DOMString qualifiedName,
- [TreatNullAs=NullString,Default=Undefined] optional DocumentType doctype);
+ [RaisesException] DocumentType createDocumentType([TreatNullAs=NullString] DOMString qualifiedName,
+ [TreatNullAs=NullString] DOMString publicId,
+ [TreatNullAs=NullString] DOMString systemId);
+ [RaisesException] Document createDocument([TreatNullAs=NullString] DOMString namespaceURI,
arv (Not doing code reviews) 2013/08/14 15:08:22 I'm concerned about this one. I've seen people cal
do-not-use 2013/08/14 15:43:02 I agree that the last argument could be optional s
+ [TreatNullAs=NullString] DOMString qualifiedName,
+ DocumentType doctype);
// DOMImplementationCSS interface from DOM Level 2 CSS

Powered by Google App Engine
This is Rietveld 408576698