Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(418)

Side by Side Diff: Source/core/dom/DOMImplementation.idl

Issue 22875013: Make several DOMImplementation API arguments mandatory (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2007 Apple Inc. All rights reserved. 2 * Copyright (C) 2006, 2007 Apple Inc. All rights reserved.
3 * Copyright (C) 2006 Samuel Weinig <sam.weinig@gmail.com> 3 * Copyright (C) 2006 Samuel Weinig <sam.weinig@gmail.com>
4 * 4 *
5 * This library is free software; you can redistribute it and/or 5 * This library is free software; you can redistribute it and/or
6 * modify it under the terms of the GNU Library General Public 6 * modify it under the terms of the GNU Library General Public
7 * License as published by the Free Software Foundation; either 7 * License as published by the Free Software Foundation; either
8 * version 2 of the License, or (at your option) any later version. 8 * version 2 of the License, or (at your option) any later version.
9 * 9 *
10 * This library is distributed in the hope that it will be useful, 10 * This library is distributed in the hope that it will be useful,
11 * but WITHOUT ANY WARRANTY; without even the implied warranty of 11 * but WITHOUT ANY WARRANTY; without even the implied warranty of
12 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU 12 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
13 * Library General Public License for more details. 13 * Library General Public License for more details.
14 * 14 *
15 * You should have received a copy of the GNU Library General Public License 15 * You should have received a copy of the GNU Library General Public License
16 * along with this library; see the file COPYING.LIB. If not, write to 16 * along with this library; see the file COPYING.LIB. If not, write to
17 * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor, 17 * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
18 * Boston, MA 02110-1301, USA. 18 * Boston, MA 02110-1301, USA.
19 */ 19 */
20 20
21 [ 21 [
22 GenerateIsReachable=document 22 GenerateIsReachable=document
23 ] interface DOMImplementation { 23 ] interface DOMImplementation {
24 24
25 // DOM Level 1 25 // DOM Level 1
26 26
27 boolean hasFeature([Default=Undefined] optional DOMString feature, 27 boolean hasFeature(DOMString feature, [TreatNullAs=NullString] DOMString ve rsion);
arv (Not doing code reviews) 2013/08/14 15:08:22 These changes make little sense. A nullable param
28 [TreatNullAs=NullString,Default=Undefined] optional DOMString version);
29 28
30 // DOM Level 2 29 // DOM Level 2
31 30
32 [RaisesException] DocumentType createDocumentType([TreatNullAs=NullString, TreatUndefinedAs=NullString,Default=Undefined] optional DOMString qualifiedName, 31 [RaisesException] DocumentType createDocumentType([TreatNullAs=NullString] DOMString qualifiedName,
33 [TreatNullAs=NullString, Trea tUndefinedAs=NullString,Default=Undefined] optional DOMString publicId, 32 [TreatNullAs=NullString] DOMString publicId,
34 [TreatNullAs=NullString, Trea tUndefinedAs=NullString,Default=Undefined] optional DOMString systemId); 33 [TreatNullAs=NullString] DOMString systemId);
35 [RaisesException] Document createDocument([TreatNullAs=NullString,Default=U ndefined] optional DOMString namespaceURI, 34 [RaisesException] Document createDocument([TreatNullAs=NullString] DOMStrin g namespaceURI,
arv (Not doing code reviews) 2013/08/14 15:08:22 I'm concerned about this one. I've seen people cal
do-not-use 2013/08/14 15:43:02 I agree that the last argument could be optional s
36 [TreatNullAs=NullString,Default=Undef ined] optional DOMString qualifiedName, 35 [TreatNullAs=NullString] DOMStrin g qualifiedName,
37 [TreatNullAs=NullString,Default=Undef ined] optional DocumentType doctype); 36 DocumentType doctype);
38 37
39 // DOMImplementationCSS interface from DOM Level 2 CSS 38 // DOMImplementationCSS interface from DOM Level 2 CSS
40 39
41 CSSStyleSheet createCSSStyleSheet([Default=Undefined] optional DOMString ti tle, 40 CSSStyleSheet createCSSStyleSheet([Default=Undefined] optional DOMString ti tle,
42 [Default=Undefined] optional DOMString me dia); 41 [Default=Undefined] optional DOMString me dia);
43 42
44 // HTMLDOMImplementation interface from DOM Level 2 HTML 43 // HTMLDOMImplementation interface from DOM Level 2 HTML
45 44
46 HTMLDocument createHTMLDocument([Default=NullString] optional DOMString titl e); 45 HTMLDocument createHTMLDocument([Default=NullString] optional DOMString titl e);
47 }; 46 };
48 47
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698