Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 2287433002: Make Dictionary::toV8Impl return v8::Undefined() (Closed)

Created:
4 years, 3 months ago by haraken
Modified:
4 years, 3 months ago
Reviewers:
bashi
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make Dictionary::toV8Impl return v8::Undefined() I'm now making toV8() never return an empty handle. This CL makes Dictionary::toV8Impl return v8::Undefined() instead of an empty handle. This shouldn't change any web-exposed behavior, since V8 interprets a returned empty handle as v8::Undefined(). BUG=625512 Committed: https://crrev.com/5eb32ca62f5540448259a9df83a9752ac733257d Cr-Commit-Position: refs/heads/master@{#415228}

Patch Set 1 #

Messages

Total messages: 19 (9 generated)
haraken
PTAL
4 years, 3 months ago (2016-08-26 09:24:36 UTC) #2
bashi
lgtm
4 years, 3 months ago (2016-08-28 23:01:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2287433002/1
4 years, 3 months ago (2016-08-28 23:01:11 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/131507)
4 years, 3 months ago (2016-08-29 00:13:43 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2287433002/1
4 years, 3 months ago (2016-08-29 16:45:17 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2287433002/1
4 years, 3 months ago (2016-08-29 21:57:07 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/283773)
4 years, 3 months ago (2016-08-30 04:51:53 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2287433002/1
4 years, 3 months ago (2016-08-30 04:57:24 UTC) #16
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-30 06:52:56 UTC) #17
commit-bot: I haz the power
4 years, 3 months ago (2016-08-30 06:54:26 UTC) #19
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5eb32ca62f5540448259a9df83a9752ac733257d
Cr-Commit-Position: refs/heads/master@{#415228}

Powered by Google App Engine
This is Rietveld 408576698